Re: [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed

Re: [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed

[O.Sezer]

A similar export should also be needed for __neigh_for_each_release :

/sbin/depmod -ae -F System.map 2.4.28-rc3aac2
depmod: *** Unresolved symbols in 
/lib/modules/2.4.28-rc3aac2/kernel/net/atm/clip.o
depmod: 	__neigh_for_each_release

Ozkan Sezer

Re: [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed

[David S. Miller]

On Mon, 15 Nov 2004 17:27:56 +0200
"O.Sezer" <sezeroz@ttnet.net.tr> wrote:

> A similar export should also be needed for __neigh_for_each_release :
> 
> /sbin/depmod -ae -F System.map 2.4.28-rc3aac2
> depmod: *** Unresolved symbols in 
> /lib/modules/2.4.28-rc3aac2/kernel/net/atm/clip.o
> depmod: 	__neigh_for_each_release

Good catch, I've fixed this in my tree and will push
upstream.

[patch] 2.4.28-rc3: __neigh_for_each_release must be EXPORT_SYMBOL'ed

[Adrian Bunk]

On Mon, Nov 15, 2004 at 05:27:56PM +0200, O.Sezer wrote:

> A similar export should also be needed for __neigh_for_each_release :
> 
> /sbin/depmod -ae -F System.map 2.4.28-rc3aac2
> depmod: *** Unresolved symbols in 
> /lib/modules/2.4.28-rc3aac2/kernel/net/atm/clip.o
> depmod: 	__neigh_for_each_release


Thanks for this report.

For some strange reason, this wasn't covered by the modular .config I 
used for testing...

Patch (on top of my other patch) below.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.4.28-rc3-modular/net/core/neighbour.c.old	2004-11-15 22:14:54.000000000 +0100
+++ linux-2.4.28-rc3-modular/net/core/neighbour.c	2004-11-15 22:15:19.000000000 +0100
@@ -1597,6 +1597,7 @@
 		}
 	}
 }
+EXPORT_SYMBOL(__neigh_for_each_release);
 
 #ifdef CONFIG_PROC_FS
 

Linux 2.4.28-rc3

[Marcelo Tosatti]

Hi,

Here goes the third release candidate.

It contains a v2.6 backport of the binfmt_elf potential vulnerabilities 
disclosed this week, an enhanced smbfs client overflow fix, an ACPI update 
fixing a couple of nasty bugs, a NFS client bugfix and a network update
from Davem.



Summary of changes from v2.4.28-rc2 to v2.4.28-rc3
============================================

Aaron Grothe:
  o [CRYPTO]: Add Anubis support

Chris Wright:
  o binfmt_elf: handle partial reads gracefully

David S. Miller:
  o [TG3]: Use ioremap_nocache()
  o [TG3]: Bump driver version and reldate
  o Cset exclude: davem@nuts.davemloft.net|ChangeSet|20040831000448|00808
  o Cset exclude: pablo@eurodev.net|ChangeSet|20040831000223|00117
  o [ATM]: Put back mistakedly removed LEC procfs code

Herbert Xu:
  o [NET]: Fix tbl->entries race

Len Brown:
  o [ACPI] fix ASUS boot crash http://bugzilla.kernel.org/show_bug.cgi?id=2755
  o [ACPI] fix poweroff regression backport from 2.6 and ACPICA 20040427 http://bugzilla.kernel.org/show_bug.cgi?id=2109

Marcelo Tosatti:
  o Changed EXTRAVERSION to -rc3

Mike Miller:
  o cleans up warnings in 32/64-bit conversions

Mike Waychison:
  o [TG3]: Fix fiber hw autoneg bounces

Patrick McHardy:
  o [PKT_SCHED]: Don't try to destroy builtin qdiscs

Stefan Esser:
  o Improved smbfs client overflow fix

Thomas Graf:
  o [NET]: Fix neighbour/arp build
  o [PKT_SCHED]: break is not enough to stop walking

Trond Myklebust:
  o NFS: Always wake up tasks that are waiting on the sillyrenamed file to complete

Wensong Zhang:
  o [IPVS]: Update version to 1.2.1

[patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed

[Adrian Bunk]

I'm getting the following error:

<--  snip  -->

depmod: *** Unresolved symbols in /lib/modules/2.4.28-rc3/kernel/net/decnet/decnet.o
depmod:         neigh_for_each

<--  snip  -->


This was caused by Harald's backport of the neighbour scalability fixes 
from 2.6 .


neigh_for_each must be EXPORT_SYMBOL'ed (as it is in 2.6):


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.4.28-rc3-modular/net/core/Makefile.old	2004-11-13 19:40:36.000000000 +0100
+++ linux-2.4.28-rc3-modular/net/core/Makefile	2004-11-13 19:40:50.000000000 +0100
@@ -9,7 +9,7 @@
 
 O_TARGET := core.o
 
-export-objs := netfilter.o profile.o ethtool.o
+export-objs := netfilter.o profile.o ethtool.o neighbour.o
 
 obj-y := sock.o skbuff.o iovec.o datagram.o scm.o
 
--- linux-2.4.28-rc3-modular/net/core/neighbour.c.old	2004-11-13 19:35:26.000000000 +0100
+++ linux-2.4.28-rc3-modular/net/core/neighbour.c	2004-11-13 19:35:59.000000000 +0100
@@ -1569,6 +1569,7 @@
 	}
 	read_unlock_bh(&tbl->lock);
 }
+EXPORT_SYMBOL(neigh_for_each);
 
 /* The tbl->lock must be held as a writer and BH disabled. */
 void __neigh_for_each_release(struct neigh_table *tbl,

Re: [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed

[David S. Miller]

On Sat, 13 Nov 2004 21:07:35 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> neigh_for_each must be EXPORT_SYMBOL'ed (as it is in 2.6):

Good catch Adrian, I'll apply this and push it to
Marcelo.

Thanks.