Re: [PATCH] PNP support for i8042 driver

matthieu castet
2004-11-14T12:22:27Z

Dmitry Torokhov wrote:
> On Saturday 13 November 2004 08:23 am, matthieu castet wrote:
>
>>Hi,
>>this patch add PNP support for the i8042 driver in 2.6.10-rc1-mm5. Acpi
>>is try before the pnp driver so if you don't disable ACPI or apply
>>others pnpacpi patches, it won't change anything.
>>
>>Please review it and apply if possible
>>
>>thanks,
>>
>>Matthieu CASTET
>>
>>Signed-Off-By: Matthieu Castet <castet.matthieu@free.fr>
>>
>
> Hi,
>
Hi,
> Do we really need to keep those drivers loaded - i8042 will not
> be hotplugged and ports are reserved anyway. We are only interested
> in presence of the keyboard and mouse ports. Can we unregister
> the drivers (both ACPI and PNP) right after registering and mark
> all that stuff as __init/__initdata as in the patch below?
It is better to keep pnp driver loaded because when it unload, the
resources will be disabled, so for the motherboards that allow it the
irq won't work anymore, and so the keyboard and mouse won't work...
Also it avoid the user to do
"echo disable > /sys/bus/pnp/xx\:xx/resources". Actually, it disables
the resources for the mouse even if the driver is using the resource...

> I also adjusted init logic so ACPI/PNP can be enabled/disabled
> independently of each other.
>
No problem as long as :
-if there is no acpi support, pnp can be used
-if acpi driver detect nothing, and there is pnp support, pnp driver
will be tried before returning an error (it is important because, in the
future pnpacpi will "lock" the acpi device, so the acpi driver will find
nothing even if there are devices)

Regards,

Matthieu