From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
dhowells@redhat.com, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] Making compound pages mandatory
Date: Wed, 17 Nov 2004 14:42:53 +1100 [thread overview]
Message-ID: <419AC8BD.40302@yahoo.com.au> (raw)
In-Reply-To: <419AC783.5040909@yahoo.com.au>
Nick Piggin wrote:
> -static inline void get_page(struct page *page)
> -{
> - atomic_inc(&page->_count);
> -}
> -
> +void put_compound_page(struct page *page);
> static inline void put_page(struct page *page)
> {
> + if (unlikely(PageCompound(page)))
> + put_compound_page(page);
===> return;
===> }
> if (!PageReserved(page) && put_page_testzero(page))
> __page_cache_release(page);
> }
... and that's something close to what it should look like.
Sorry, not having a good day today :\
Ignoring me might be the best option.
next prev parent reply other threads:[~2004-11-17 3:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 18:48 [RFC] Making compound pages mandatory David Howells
2004-11-16 19:20 ` Andrew Morton
2004-11-16 19:41 ` David Howells
2004-11-17 1:50 ` Linus Torvalds
2004-11-17 2:28 ` Andrew Morton
2004-11-17 3:13 ` Nick Piggin
2004-11-17 3:22 ` Nick Piggin
2004-11-17 3:37 ` Nick Piggin
2004-11-17 3:42 ` Nick Piggin [this message]
2004-11-17 3:14 ` Linus Torvalds
2004-11-17 12:03 ` David Howells
2004-11-17 11:47 ` David Howells
2004-11-17 11:43 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419AC8BD.40302@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox