From: Jesper Juhl <juhl-lkml@dif.dk>
To: James Morris <jmorris@redhat.com>
Cc: "Luiz Fernando N. Capitulino" <lcapitulino@conectiva.com.br>,
linux-kernel@vger.kernel.org, akpm@osdl.org, davem@davemloft.net
Subject: Re: [PATCH 1/2] - net/socket.c::sys_bind() cleanup.
Date: Wed, 17 Nov 2004 10:55:18 +0100 [thread overview]
Message-ID: <419B2006.3070609@dif.dk> (raw)
In-Reply-To: <Xine.LNX.4.44.0411162315420.29418-100000@thoron.boston.redhat.com>
James Morris wrote:
> On Wed, 17 Nov 2004, Jesper Juhl wrote:
>
>
>>Not exactely :
>>
>>
>>
>>>- if((err=move_addr_to_kernel(umyaddr,addrlen,address))>=0) {
>>
>>>+ err = move_addr_to_kernel(umyaddr, addrlen, address);
>>>+ if (err)
>>>+ goto out_put;
>>
>>
>>The original tests for err >= 0, your replacement tests if err is != 0
>
>
> Look at move_addr_to_kernel(), it only returns 0 or -error.
>
> The patch looks good to me.
>
Right, I had not looked at it in detail. I just reacted to the claim
that "it does exactely the same" but I could see in the posted patch
that it didn't do exactely the same and there was no explanation of why
it was ok to have that difference.
After reading move_addr_to_kernel(), I agree that the patch looks fine.
--
Jesper Juhl
prev parent reply other threads:[~2004-11-17 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 20:55 [PATCH 1/2] - net/socket.c::sys_bind() cleanup Luiz Fernando N. Capitulino
2004-11-17 0:52 ` Jesper Juhl
2004-11-17 4:16 ` James Morris
2004-11-17 9:55 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419B2006.3070609@dif.dk \
--to=juhl-lkml@dif.dk \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=lcapitulino@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox