From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Colin Leroy <colin.lkml@colino.net>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Switch therm_adt746x to new module_param
Date: Wed, 17 Nov 2004 10:43:41 -0800 [thread overview]
Message-ID: <419B9BDD.7030805@osdl.org> (raw)
In-Reply-To: <20041117193416.52a86d03.colin.lkml@colino.net>
Colin Leroy wrote:
> Hi Andrew,
>
> this patch replaces MODULE_PARM to module_param for adt746x.
>
> Signed-off-by: Colin Leroy <colin@colino.net>
> --- a/drivers/macintosh/therm_adt746x.c 2004-11-17 19:26:16.908413504 +0100
> +++ b/drivers/macintosh/therm_adt746x.c 2004-11-17 19:28:01.193559752 +0100
> @@ -56,11 +57,11 @@
> "Powerbook G4 Alu");
> MODULE_LICENSE("GPL");
>
> -MODULE_PARM(limit_adjust,"i");
> +module_param(limit_adjust, int, 0);
> MODULE_PARM_DESC(limit_adjust,"Adjust maximum temperatures (50 cpu, 70 gpu) "
> "by N degrees.");
>
> -MODULE_PARM(fan_speed,"i");
> +module_param(fan_speed, int, 64);
The last parameter here (64) is not an init. value nor a
suggested parameter value.
It's a permission for an entry in /sys (sysfs).
0 means not visible there.
If it should be visible there, use something like
0444 (read-only by anyone) or 0644 (read-write by root).
> MODULE_PARM_DESC(fan_speed,"Specify starting fan speed (0-255) "
> "(default 64)");
--
~Randy
next prev parent reply other threads:[~2004-11-17 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 18:34 [PATCH] Switch therm_adt746x to new module_param Colin Leroy
2004-11-17 18:43 ` Randy.Dunlap [this message]
2004-11-17 19:51 ` Colin Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419B9BDD.7030805@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=colin.lkml@colino.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox