Re: [Alsa-devel] Re: Linux 2.6.10-rc2

[Bill Davidsen <davidsen@tmr.com>]

Takashi Iwai wrote:
> At Mon, 15 Nov 2004 16:16:31 -0500,
> Lee Revell wrote:
> 
>>Please report ALSA issues to alsa-devel@lists.sourceforge.net.  I have
>>added them to the cc:.
> 
> 
> The attached patch should fix this.
> 
> 
> Takashi
> 
> ==
> Summary: [ALSA] fix sleep in atomic during prepare callback
> 
> Fixed the sleep in spinlock during prepare callback.
> This happened only on Nforce chips.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> --- linux/sound/pci/intel8x0.c	15 Nov 2004 14:19:52 -0000	1.173
> +++ linux/sound/pci/intel8x0.c	16 Nov 2004 09:41:47 -0000
> @@ -1020,7 +1020,9 @@ static void snd_intel8x0_setup_pcm_out(i
>  			 */
>  			if (cnt & ICH_PCM_246_MASK) {
>  				iputdword(chip, ICHREG(GLOB_CNT), cnt & ~ICH_PCM_246_MASK);
> +				spin_unlock_irq(&chip->reg_lock);
>  				msleep(50); /* grrr... */
> +				spin_lock_irq(&chip->reg_lock);
>  			}
>  		} else if (chip->device_type == DEVICE_INTEL_ICH4) {
>  			if (runtime->sample_bits > 16)

Might this make it into 2.6.10?

-- 
    -bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
  last possible moment - but no longer"  -me