* [PATCH] usb-storage should enable scsi disk in Kconfig @ 2004-11-19 19:33 Stelian Pop 2004-11-19 19:57 ` Christoph Hellwig 0 siblings, 1 reply; 10+ messages in thread From: Stelian Pop @ 2004-11-19 19:33 UTC (permalink / raw) To: mdharm-usb; +Cc: Linux Kernel Mailing List, Andrew Morton As $subject says, usb-storage storage should automatically enable scsi disk support in Kconfig. Please apply. Stelian. Signed-off-by: Stelian Pop <stelian@popies.net> ===== drivers/usb/storage/Kconfig 1.9 vs edited ===== --- 1.9/drivers/usb/storage/Kconfig 2004-06-13 17:24:10 +02:00 +++ edited/drivers/usb/storage/Kconfig 2004-11-19 16:44:16 +01:00 @@ -6,6 +6,7 @@ tristate "USB Mass Storage support" depends on USB select SCSI + select BLK_DEV_SD ---help--- Say Y here if you want to connect USB mass storage devices to your computer's USB port. This is the driver you need for USB floppy drives, -- Stelian Pop <stelian@popies.net> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-19 19:33 [PATCH] usb-storage should enable scsi disk in Kconfig Stelian Pop @ 2004-11-19 19:57 ` Christoph Hellwig 2004-11-19 21:39 ` Stelian Pop 0 siblings, 1 reply; 10+ messages in thread From: Christoph Hellwig @ 2004-11-19 19:57 UTC (permalink / raw) To: Stelian Pop, mdharm-usb, Linux Kernel Mailing List, Andrew Morton On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote: > As $subject says, usb-storage storage should automatically enable > scsi disk support in Kconfig. > > Please apply. No, it shouldn't. There's lots of usb storage devices that don't use sd, as there are lots of SPI/FC/etc.. devices. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-19 19:57 ` Christoph Hellwig @ 2004-11-19 21:39 ` Stelian Pop 2004-11-19 23:08 ` Matthew Dharm 0 siblings, 1 reply; 10+ messages in thread From: Stelian Pop @ 2004-11-19 21:39 UTC (permalink / raw) To: Christoph Hellwig, mdharm-usb, Linux Kernel Mailing List, Andrew Morton On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote: > On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote: > > As $subject says, usb-storage storage should automatically enable > > scsi disk support in Kconfig. > > > > Please apply. > > No, it shouldn't. There's lots of usb storage devices that don't use > sd, as there are lots of SPI/FC/etc.. devices. Indeed, I should have checked more carefully. My bad. Still, it is not obvious that one should go into a completly different config section and manually enable sd support, and I have been bitten by this more than one time. Maybe we should add, just below the 'USB storage' Kconfig option another one, let's say 'SCSI disk based USB storage support', which documentation would talk about 'usb keys, memory stick readers, USB floppy drives etc', which should just be a dummy option selecting BLK_DEV_SD ? Or perhaps we should add something along the Debian's dpkg 'suggests' rule to Kconfig ? :) Stelian. -- Stelian Pop <stelian@popies.net> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-19 21:39 ` Stelian Pop @ 2004-11-19 23:08 ` Matthew Dharm 2004-11-20 23:21 ` Randy.Dunlap 0 siblings, 1 reply; 10+ messages in thread From: Matthew Dharm @ 2004-11-19 23:08 UTC (permalink / raw) To: Stelian Pop, Christoph Hellwig, Linux Kernel Mailing List, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 1575 bytes --] On Fri, Nov 19, 2004 at 10:39:42PM +0100, Stelian Pop wrote: > On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote: > > > On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote: > > > As $subject says, usb-storage storage should automatically enable > > > scsi disk support in Kconfig. > > > > > > Please apply. > > > > No, it shouldn't. There's lots of usb storage devices that don't use > > sd, as there are lots of SPI/FC/etc.. devices. > > Indeed, I should have checked more carefully. My bad. > > Still, it is not obvious that one should go into a completly different > config section and manually enable sd support, and I have been bitten > by this more than one time. > > Maybe we should add, just below the 'USB storage' Kconfig option another > one, let's say 'SCSI disk based USB storage support', which documentation > would talk about 'usb keys, memory stick readers, USB floppy drives etc', > which should just be a dummy option selecting BLK_DEV_SD ? > > Or perhaps we should add something along the Debian's dpkg 'suggests' rule > to Kconfig ? :) I get enough e-mail on this topic that we should do something about it. We need some sort of 'suggests' rule, or at least some sort of message to the user to tell them to enable the high-level drivers. Matt -- Matthew Dharm Home: mdharm-usb@one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver What, are you one of those Microsoft-bashing Linux freaks? -- Customer to Greg User Friendly, 2/10/1999 [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-19 23:08 ` Matthew Dharm @ 2004-11-20 23:21 ` Randy.Dunlap 2004-11-22 10:35 ` Stelian Pop ` (2 more replies) 0 siblings, 3 replies; 10+ messages in thread From: Randy.Dunlap @ 2004-11-20 23:21 UTC (permalink / raw) To: Matthew Dharm Cc: Stelian Pop, Christoph Hellwig, Linux Kernel Mailing List, Andrew Morton, greg [-- Attachment #1: Type: text/plain, Size: 1721 bytes --] Matthew Dharm wrote: > On Fri, Nov 19, 2004 at 10:39:42PM +0100, Stelian Pop wrote: > >>On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote: >> >> >>>On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote: >>> >>>>As $subject says, usb-storage storage should automatically enable >>>>scsi disk support in Kconfig. >>>> >>>>Please apply. >>> >>>No, it shouldn't. There's lots of usb storage devices that don't use >>>sd, as there are lots of SPI/FC/etc.. devices. >> >>Indeed, I should have checked more carefully. My bad. >> >>Still, it is not obvious that one should go into a completly different >>config section and manually enable sd support, and I have been bitten >>by this more than one time. >> >>Maybe we should add, just below the 'USB storage' Kconfig option another >>one, let's say 'SCSI disk based USB storage support', which documentation >>would talk about 'usb keys, memory stick readers, USB floppy drives etc', >>which should just be a dummy option selecting BLK_DEV_SD ? >> >>Or perhaps we should add something along the Debian's dpkg 'suggests' rule >>to Kconfig ? :) > > > I get enough e-mail on this topic that we should do something about it. > We need some sort of 'suggests' rule, or at least some sort of message to > the user to tell them to enable the high-level drivers. Until 'suggests' is available, does this help any? It's tough getting people to read Help messages though. Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also. Add a few device types to help text and reformat it. diffstat:= drivers/usb/storage/Kconfig | 15 +++++++++++---- 1 files changed, 11 insertions(+), 4 deletions(-) Signed-off-by: Randy Dunlap <rddunlap@osdl.org> [-- Attachment #2: usb_sd_comment.patch --] [-- Type: text/x-patch, Size: 1371 bytes --] diff -Naurp ./drivers/usb/storage/Kconfig~usb_comment ./drivers/usb/storage/Kconfig --- ./drivers/usb/storage/Kconfig~usb_comment 2004-10-18 14:55:28.000000000 -0700 +++ ./drivers/usb/storage/Kconfig 2004-11-20 15:15:10.640398000 -0800 @@ -2,16 +2,23 @@ # USB Storage driver configuration # +comment "NOTE: USB_STORAGE enables SCSI, and 'SCSI disk support' may also be needed; see USB_STORAGE Help for more information" + config USB_STORAGE tristate "USB Mass Storage support" depends on USB select SCSI ---help--- Say Y here if you want to connect USB mass storage devices to your - computer's USB port. This is the driver you need for USB floppy drives, - USB hard disks, USB tape drives and USB CD-ROMs, along with - similar devices. This driver may also be used for some cameras and - card readers. + computer's USB port. This is the driver you need for USB + floppy drives, USB hard disks, USB tape drives, USB CD-ROMs, + USB flash devices, and memory sticks, along with + similar devices. This driver may also be used for some cameras + and card readers. + + This option 'selects' (turns on, enables) 'SCSI', but you + probably also need 'SCSI device support: SCSI disk support' + (BLK_DEV_SD) for most USB storage devices. To compile this driver as a module, choose M here: the module will be called usb-storage. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-20 23:21 ` Randy.Dunlap @ 2004-11-22 10:35 ` Stelian Pop 2004-11-22 16:01 ` Randy.Dunlap 2004-11-22 14:52 ` Martin Waitz 2004-11-29 19:08 ` Greg KH 2 siblings, 1 reply; 10+ messages in thread From: Stelian Pop @ 2004-11-22 10:35 UTC (permalink / raw) To: Randy.Dunlap Cc: Matthew Dharm, Christoph Hellwig, Linux Kernel Mailing List, Andrew Morton, greg On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote: > >>>On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote: > >> > >>Maybe we should add, just below the 'USB storage' Kconfig option another > >>one, let's say 'SCSI disk based USB storage support', which documentation > >>would talk about 'usb keys, memory stick readers, USB floppy drives etc', > >>which should just be a dummy option selecting BLK_DEV_SD ? > Until 'suggests' is available, does this help any? > It's tough getting people to read Help messages though. > > Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also. > Add a few device types to help text and reformat it. Isn't my above suggestion even better ? A separate config option is much more visible IMHO... Stelian. -- Stelian Pop <stelian@popies.net> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-22 10:35 ` Stelian Pop @ 2004-11-22 16:01 ` Randy.Dunlap 2004-11-22 16:30 ` Stelian Pop 0 siblings, 1 reply; 10+ messages in thread From: Randy.Dunlap @ 2004-11-22 16:01 UTC (permalink / raw) To: Stelian Pop Cc: Matthew Dharm, Christoph Hellwig, Linux Kernel Mailing List, Andrew Morton, greg Stelian Pop wrote: > On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote: > > >>>>>On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote: >>>> >>>>Maybe we should add, just below the 'USB storage' Kconfig option another >>>>one, let's say 'SCSI disk based USB storage support', which documentation >>>>would talk about 'usb keys, memory stick readers, USB floppy drives etc', >>>>which should just be a dummy option selecting BLK_DEV_SD ? > > >>Until 'suggests' is available, does this help any? >>It's tough getting people to read Help messages though. >> >>Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also. >>Add a few device types to help text and reformat it. > > > Isn't my above suggestion even better ? A separate config option > is much more visible IMHO... Sounds good, as long as we don't mind the same option being settable in multiple places. Did you submit a patch? -- ~Randy ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-22 16:01 ` Randy.Dunlap @ 2004-11-22 16:30 ` Stelian Pop 0 siblings, 0 replies; 10+ messages in thread From: Stelian Pop @ 2004-11-22 16:30 UTC (permalink / raw) To: Randy.Dunlap Cc: Matthew Dharm, Christoph Hellwig, Linux Kernel Mailing List, Andrew Morton, greg On Mon, Nov 22, 2004 at 08:01:30AM -0800, Randy.Dunlap wrote: > >>>>Maybe we should add, just below the 'USB storage' Kconfig option another > >>>>one, let's say 'SCSI disk based USB storage support', which > >>>>documentation > >>>>would talk about 'usb keys, memory stick readers, USB floppy drives > >>>>etc', > >>>>which should just be a dummy option selecting BLK_DEV_SD ? > > > > > >>Until 'suggests' is available, does this help any? > >>It's tough getting people to read Help messages though. > >> > >>Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also. > >>Add a few device types to help text and reformat it. > > > > > >Isn't my above suggestion even better ? A separate config option > >is much more visible IMHO... > > Sounds good, as long as we don't mind the same option being > settable in multiple places. Did you submit a patch? Nope, I was waiting for the discussion to settle. But here it is: ===== drivers/usb/storage/Kconfig 1.9 vs edited ===== --- 1.9/drivers/usb/storage/Kconfig 2004-06-13 17:24:10 +02:00 +++ edited/drivers/usb/storage/Kconfig 2004-11-22 17:27:43 +01:00 @@ -45,6 +45,16 @@ If you say N here, the kernel will assume that all disk-like USB devices are write-enabled. +config USB_STORAGE_SD + bool "USB Mass Storage SCSI-like disks" + depends on USB_STORAGE + select BLK_DEV_SD + help + Say Y here if you want to enable support for SCSI-like USB + connected disks. These are the most used USB Mass Storage + devices, and include USB keys, USB floppy drives, most USB + flash memory readers, some USB photo cameras etc. + config USB_STORAGE_DATAFAB bool "Datafab Compact Flash Reader support (EXPERIMENTAL)" depends on USB_STORAGE && EXPERIMENTAL -- Stelian Pop <stelian@popies.net> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-20 23:21 ` Randy.Dunlap 2004-11-22 10:35 ` Stelian Pop @ 2004-11-22 14:52 ` Martin Waitz 2004-11-29 19:08 ` Greg KH 2 siblings, 0 replies; 10+ messages in thread From: Martin Waitz @ 2004-11-22 14:52 UTC (permalink / raw) To: Randy.Dunlap Cc: Matthew Dharm, Stelian Pop, Christoph Hellwig, Linux Kernel Mailing List, Andrew Morton, greg [-- Attachment #1: Type: text/plain, Size: 1003 bytes --] hoi :) On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote: > Until 'suggests' is available, does this help any? > It's tough getting people to read Help messages though. perhaps the following is enough? SCSI is auto-enabled by USB_STORAGE. We should enable BLK_DEV_SD by default in this case but we should leave the option to turn it off. Index: drivers/scsi/Kconfig =================================================================== RCS file: /home/inf3/mnwaitz/src/linux-cvs/linux-2.5/drivers/scsi/Kconfig,v retrieving revision 1.69 diff -u -p -r1.69 Kconfig --- drivers/scsi/Kconfig 14 Nov 2004 04:33:58 -0000 1.69 +++ drivers/scsi/Kconfig 22 Nov 2004 14:48:22 -0000 @@ -38,6 +38,7 @@ comment "SCSI support type (disk, tape, config BLK_DEV_SD tristate "SCSI disk support" depends on SCSI + default m ---help--- If you want to use SCSI hard disks, Fibre Channel disks, USB storage or the SCSI or parallel port version of -- Martin Waitz [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb-storage should enable scsi disk in Kconfig 2004-11-20 23:21 ` Randy.Dunlap 2004-11-22 10:35 ` Stelian Pop 2004-11-22 14:52 ` Martin Waitz @ 2004-11-29 19:08 ` Greg KH 2 siblings, 0 replies; 10+ messages in thread From: Greg KH @ 2004-11-29 19:08 UTC (permalink / raw) To: Randy.Dunlap Cc: Matthew Dharm, Stelian Pop, Christoph Hellwig, Linux Kernel Mailing List, Andrew Morton On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote: > > Until 'suggests' is available, does this help any? > It's tough getting people to read Help messages though. > > > > Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also. > Add a few device types to help text and reformat it. Applied, thanks. greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2004-11-29 19:35 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2004-11-19 19:33 [PATCH] usb-storage should enable scsi disk in Kconfig Stelian Pop 2004-11-19 19:57 ` Christoph Hellwig 2004-11-19 21:39 ` Stelian Pop 2004-11-19 23:08 ` Matthew Dharm 2004-11-20 23:21 ` Randy.Dunlap 2004-11-22 10:35 ` Stelian Pop 2004-11-22 16:01 ` Randy.Dunlap 2004-11-22 16:30 ` Stelian Pop 2004-11-22 14:52 ` Martin Waitz 2004-11-29 19:08 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox