Re: [PATCH 1/2] pci: Block config access during BIST

Benjamin Herrenschmidt
2004-11-21T00:13:18Z

On Sat, 2004-11-20 at 17:38 -0600, Brian King wrote:
> Alan Cox wrote:
> > Some of the Intel CPU's are very bad at lock handling so it is an issue.
> > Also most PCI config accesses nowdays go to onboard devices whose
> > behaviour may well be quite different to PCI anyway. PCI has become a
> > device management API.
>
> Does this following patch address your issues with this patch, Alan?
>
> It still doesn't address Greg's issue about making this apply to the
> pci_bus_* functions as well, but I'm not sure of a good way to do that
> due to the reasons given earlier.

Looks good to me, I don't sure we actually have to deal with pci_bus_*
functions, do we ? When are they called ?

> +void pci_block_config_access(struct pci_dev *dev)
> +{
> + unsigned long flags;
> +
> + spin_lock_irqsave(&pci_lock, flags);
> + dev->block_cfg_access = 1;
> + spin_unlock_irqrestore(&pci_lock, flags);
> +}

Shouldn't we save the config space here ?

Ben.