[PATCH 00/10] Use SoC-specific compatible string for Samsung MFC

[PATCH 00/10] Use SoC-specific compatible string for Samsung MFC

[Aakarsh Jain]

This patch series modifies the samsung MFC version compatible to
SoC-specific compatible.

Aakarsh Jain (10):
  ARM: dts: samsung: exynos3250: Use SoC-specific compatible string for
    MFC
  ARM: dts: samsung: exynos4: Use SoC-specific compatible string for MFC
  ARM: dts: samsung: exynos5250: Use SoC-specific compatible string for
    MFC
  ARM: dts: samsung: exynos5420: Use SoC-specific compatible string for
    MFC
  ARM: dts: samsung: exynos5800: Use SoC-specific compatible string for
    MFC
  ARM: dts: samsung: s5pv210: Use SoC-specific compatible string for MFC
  media: s5p-mfc: Modify compatible string check for SoC-specific
    support
  media: s5p-mfc: Add new compatible string corresponding to S5pv210 SoC
  dt-bindings: media: s5p-mfc: Modify compatible string check for
    SoC-specific support
  dt-bindings: media: s5p-mfc: Add SoC-specific compatible for
    'samsung,mfc-v5'

 .../bindings/media/samsung,s5p-mfc.yaml       | 24 ++++++++++---------
 arch/arm/boot/dts/samsung/exynos3250.dtsi     |  2 +-
 arch/arm/boot/dts/samsung/exynos4.dtsi        |  2 +-
 arch/arm/boot/dts/samsung/exynos5250.dtsi     |  2 +-
 arch/arm/boot/dts/samsung/exynos5420.dtsi     |  2 +-
 arch/arm/boot/dts/samsung/exynos5800.dtsi     |  2 +-
 arch/arm/boot/dts/samsung/s5pv210.dtsi        |  2 +-
 .../media/platform/samsung/s5p-mfc/s5p_mfc.c  | 13 ++++++----
 8 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.49.0

[PATCH 01/10] ARM: dts: samsung: exynos3250: Use SoC-specific compatible string for MFC

[Aakarsh Jain]

Modify the MFC device tree node to use a SoC-specific
compatible string instead of a generic one.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm/boot/dts/samsung/exynos3250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/exynos3250.dtsi b/arch/arm/boot/dts/samsung/exynos3250.dtsi
index b6c3826a9424..1fd99c4ccca8 100644
--- a/arch/arm/boot/dts/samsung/exynos3250.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos3250.dtsi
@@ -657,7 +657,7 @@ gpu: gpu@13000000 {
 		};
 
 		mfc: codec@13400000 {
-			compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
+			compatible = "samsung,exynos3250-mfc", "samsung,exynos5420-mfc";
 			reg = <0x13400000 0x10000>;
 			interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "mfc", "sclk_mfc";
-- 
2.49.0

[PATCH 02/10] ARM: dts: samsung: exynos4: Use SoC-specific compatible string for MFC

[Aakarsh Jain]

Modify the MFC device tree node to use a SoC-specific
compatible string instead of a generic one.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm/boot/dts/samsung/exynos4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
index ed47d0ce04e1..a2f15fbe98cb 100644
--- a/arch/arm/boot/dts/samsung/exynos4.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
@@ -435,7 +435,7 @@ i2s2: i2s@13970000 {
 		};
 
 		mfc: codec@13400000 {
-			compatible = "samsung,mfc-v5";
+			compatible = "samsung,exynos4-mfc";
 			reg = <0x13400000 0x10000>;
 			interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
 			power-domains = <&pd_mfc>;
-- 
2.49.0

Re: [PATCH 02/10] ARM: dts: samsung: exynos4: Use SoC-specific compatible string for MFC

[Krzysztof Kozlowski]

On 07/08/2025 05:24, Aakarsh Jain wrote:
> Modify the MFC device tree node to use a SoC-specific
> compatible string instead of a generic one.

Why?

> 
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> ---
>  arch/arm/boot/dts/samsung/exynos4.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
> index ed47d0ce04e1..a2f15fbe98cb 100644
> --- a/arch/arm/boot/dts/samsung/exynos4.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
> @@ -435,7 +435,7 @@ i2s2: i2s@13970000 {
>  		};
>  
>  		mfc: codec@13400000 {
> -			compatible = "samsung,mfc-v5";
> +			compatible = "samsung,exynos4-mfc";

There are so many things wrong here...

1. This breaks all users
2. Not a correct compatible - there is no exynos4 (see writing bindings)
3. Commit msg does not explain why breaking users is reasonable


Best regards,
Krzysztof

Re: [PATCH 02/10] ARM: dts: samsung: exynos4: Use SoC-specific compatible string for MFC

[Krzysztof Kozlowski]

On 07/08/2025 12:59, Krzysztof Kozlowski wrote:
> On 07/08/2025 05:24, Aakarsh Jain wrote:
>> Modify the MFC device tree node to use a SoC-specific
>> compatible string instead of a generic one.
> 
> Why?
> 
>>
>> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
>> ---
>>  arch/arm/boot/dts/samsung/exynos4.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
>> index ed47d0ce04e1..a2f15fbe98cb 100644
>> --- a/arch/arm/boot/dts/samsung/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
>> @@ -435,7 +435,7 @@ i2s2: i2s@13970000 {
>>  		};
>>  
>>  		mfc: codec@13400000 {
>> -			compatible = "samsung,mfc-v5";
>> +			compatible = "samsung,exynos4-mfc";
> 
> There are so many things wrong here...
> 
> 1. This breaks all users
> 2. Not a correct compatible - there is no exynos4 (see writing bindings)
> 3. Commit msg does not explain why breaking users is reasonable

Ah and 4: there is no such compatible, so this fails tests.

Best regards,
Krzysztof

[PATCH 03/10] ARM: dts: samsung: exynos5250: Use SoC-specific compatible string for MFC

[Aakarsh Jain]

Modify the MFC device tree node to use a SoC-specific
compatible string instead of a generic one.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm/boot/dts/samsung/exynos5250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/exynos5250.dtsi b/arch/arm/boot/dts/samsung/exynos5250.dtsi
index b9e7c4938818..c4d9a4a3f78d 100644
--- a/arch/arm/boot/dts/samsung/exynos5250.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5250.dtsi
@@ -316,7 +316,7 @@ watchdog@101d0000 {
 		};
 
 		mfc: codec@11000000 {
-			compatible = "samsung,mfc-v6";
+			compatible = "samsung,exynos5250-mfc";
 			reg = <0x11000000 0x10000>;
 			interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
 			power-domains = <&pd_mfc>;
-- 
2.49.0

[PATCH 04/10] ARM: dts: samsung: exynos5420: Use SoC-specific compatible string for MFC

[Aakarsh Jain]

Modify the MFC device tree node to use a SoC-specific
compatible string instead of a generic one.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm/boot/dts/samsung/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/exynos5420.dtsi b/arch/arm/boot/dts/samsung/exynos5420.dtsi
index 196c6d04675a..31738350b522 100644
--- a/arch/arm/boot/dts/samsung/exynos5420.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5420.dtsi
@@ -299,7 +299,7 @@ clock_audss: audss-clock-controller@3810000 {
 		};
 
 		mfc: codec@11000000 {
-			compatible = "samsung,mfc-v7";
+			compatible = "samsung,exynos5420-mfc";
 			reg = <0x11000000 0x10000>;
 			interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clock CLK_MFC>;
-- 
2.49.0

[PATCH 05/10] ARM: dts: samsung: exynos5800: Use SoC-specific compatible string for MFC

[Aakarsh Jain]

Modify the MFC device tree node to use a SoC-specific
compatible string instead of a generic one.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm/boot/dts/samsung/exynos5800.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/exynos5800.dtsi b/arch/arm/boot/dts/samsung/exynos5800.dtsi
index 72d3a3535a7a..8abaf79165a6 100644
--- a/arch/arm/boot/dts/samsung/exynos5800.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5800.dtsi
@@ -153,7 +153,7 @@ &dsi {
 };
 
 &mfc {
-	compatible = "samsung,mfc-v8";
+	compatible = "samsung,exynos5800-mfc";
 };
 
 &soc {
-- 
2.49.0

[PATCH 06/10] ARM: dts: samsung: s5pv210: Use SoC-specific compatible string for MFC

[Aakarsh Jain]

Modify the MFC device tree node to use a SoC-specific
compatible string instead of a generic one.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm/boot/dts/samsung/s5pv210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/s5pv210.dtsi b/arch/arm/boot/dts/samsung/s5pv210.dtsi
index 34e8a3d5efa5..0a746c2243f8 100644
--- a/arch/arm/boot/dts/samsung/s5pv210.dtsi
+++ b/arch/arm/boot/dts/samsung/s5pv210.dtsi
@@ -450,7 +450,7 @@ ohci: usb@ec300000 {
 		};
 
 		mfc: codec@f1700000 {
-			compatible = "samsung,mfc-v5";
+			compatible = "samsung,s5pv210-mfc";
 			reg = <0xf1700000 0x10000>;
 			interrupt-parent = <&vic2>;
 			interrupts = <14>;
-- 
2.49.0

[PATCH 07/10] media: s5p-mfc: Modify compatible string check for SoC-specific support

[Aakarsh Jain]

Modify the compatible string handling in the MFC driver
to explicitly match SoC-specific identifiers.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
index 73fdcd362265..d13770058e63 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
@@ -1711,22 +1711,22 @@ static const struct of_device_id exynos_mfc_match[] = {
 		.compatible = "samsung,mfc-v5",
 		.data = &mfc_drvdata_v5,
 	}, {
-		.compatible = "samsung,mfc-v6",
+		.compatible = "samsung,exynos5250-mfc",
 		.data = &mfc_drvdata_v6,
 	}, {
-		.compatible = "samsung,mfc-v7",
+		.compatible = "samsung,exynos5420-mfc",
 		.data = &mfc_drvdata_v7,
 	}, {
 		.compatible = "samsung,exynos3250-mfc",
 		.data = &mfc_drvdata_v7_3250,
 	}, {
-		.compatible = "samsung,mfc-v8",
+		.compatible = "samsung,exynos5800-mfc",
 		.data = &mfc_drvdata_v8,
 	}, {
 		.compatible = "samsung,exynos5433-mfc",
 		.data = &mfc_drvdata_v8_5433,
 	}, {
-		.compatible = "samsung,mfc-v10",
+		.compatible = "samsung,exynos7880-mfc",
 		.data = &mfc_drvdata_v10,
 	}, {
 		.compatible = "tesla,fsd-mfc",
-- 
2.49.0

Re: [PATCH 07/10] media: s5p-mfc: Modify compatible string check for SoC-specific support

[Krzysztof Kozlowski]

On 07/08/2025 05:24, Aakarsh Jain wrote:
> Modify the compatible string handling in the MFC driver
> to explicitly match SoC-specific identifiers.
> 
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>

Please read maintainer soc profile, submitting patches in DT dir and
writing bindings. You just broke all platforms without even admitting it
and without providing rationale.

Best regards,
Krzysztof

[PATCH 08/10] media: s5p-mfc: Add new compatible string corresponding to S5pv210 SoC

[Aakarsh Jain]

'samsung,mfc-v5' compatible string was getting used for both S5pv210
and Exynos4 SoC. Based on SoC-specific, modify existing 'samsung,mfc-v5'
compatible to 'samsung,s5pv210-mfc' and add its variant data. Add new
compatible for Exynos4.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
index d13770058e63..f8476bc3a5ce 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
@@ -1708,7 +1708,10 @@ static struct s5p_mfc_variant mfc_drvdata_v12 = {
 
 static const struct of_device_id exynos_mfc_match[] = {
 	{
-		.compatible = "samsung,mfc-v5",
+		.compatible = "samsung,s5pv210-mfc",
+		.data = &mfc_drvdata_v5,
+	}, {
+		.compatible = "samsung,exynos4-mfc",
 		.data = &mfc_drvdata_v5,
 	}, {
 		.compatible = "samsung,exynos5250-mfc",
-- 
2.49.0

[PATCH 09/10] dt-bindings: media: s5p-mfc: Modify compatible string check for SoC-specific support

[Aakarsh Jain]

Modify compatible strings in the s5p-mfc binding to reflect
accurate SoC-specific naming across multiple Samsung platforms.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 .../bindings/media/samsung,s5p-mfc.yaml          | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
index b46cc780703c..6a711c8103ac 100644
--- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
+++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
@@ -20,15 +20,15 @@ properties:
       - enum:
           - samsung,exynos5433-mfc        # Exynos5433
           - samsung,mfc-v5                # Exynos4
-          - samsung,mfc-v6                # Exynos5
-          - samsung,mfc-v7                # Exynos5420
-          - samsung,mfc-v8                # Exynos5800
-          - samsung,mfc-v10               # Exynos7880
+          - samsung,exynos5250-mfc        # Exynos5
+          - samsung,exynos5420-mfc        # Exynos5420
+          - samsung,exynos5800-mfc        # Exynos5800
+          - samsung,exynos7880-mfc        # Exynos7880
           - tesla,fsd-mfc                 # Tesla FSD
       - items:
           - enum:
               - samsung,exynos3250-mfc    # Exynos3250
-          - const: samsung,mfc-v7         # Fall back for Exynos3250
+          - const: samsung,exynos5420-mfc # Fall back for Exynos3250
 
   reg:
     maxItems: 1
@@ -133,8 +133,8 @@ allOf:
         compatible:
           contains:
             enum:
-              - samsung,mfc-v6
-              - samsung,mfc-v8
+              - samsung,exynos5250-mfc
+              - samsung,exynos5800-mfc
     then:
       properties:
         clocks:
@@ -152,7 +152,7 @@ allOf:
         compatible:
           contains:
             enum:
-              - samsung,mfc-v7
+              - samsung,exynos5420-mfc
     then:
       properties:
         clocks:
-- 
2.49.0

Re: [PATCH 09/10] dt-bindings: media: s5p-mfc: Modify compatible string check for SoC-specific support

[Krzysztof Kozlowski]

On 07/08/2025 05:24, Aakarsh Jain wrote:
> Modify compatible strings in the s5p-mfc binding to reflect
> accurate SoC-specific naming across multiple Samsung platforms.
> 
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> ---
>  .../bindings/media/samsung,s5p-mfc.yaml          | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> index b46cc780703c..6a711c8103ac 100644
> --- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> +++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> @@ -20,15 +20,15 @@ properties:
>        - enum:
>            - samsung,exynos5433-mfc        # Exynos5433
>            - samsung,mfc-v5                # Exynos4
> -          - samsung,mfc-v6                # Exynos5
> -          - samsung,mfc-v7                # Exynos5420
> -          - samsung,mfc-v8                # Exynos5800
> -          - samsung,mfc-v10               # Exynos7880
> +          - samsung,exynos5250-mfc        # Exynos5
> +          - samsung,exynos5420-mfc        # Exynos5420
> +          - samsung,exynos5800-mfc        # Exynos5800
> +          - samsung,exynos7880-mfc        # Exynos7880

NAK, ABI break without any valid reason or explanation why.

Best regards,
Krzysztof

[PATCH 10/10] dt-bindings: media: s5p-mfc: Add SoC-specific compatible for 'samsung,mfc-v5'

[Aakarsh Jain]

'samsung,mfc-v5' compatible string was getting used for both S5pv210
and Exynos4 SoC. Based on SoC-specific, modify existing 'samsung,mfc-v5'
compatible to 'samsung,exynos4-mfc'. Add new compatible for s5pv210.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 .../devicetree/bindings/media/samsung,s5p-mfc.yaml     | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
index 6a711c8103ac..922b1de66736 100644
--- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
+++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
@@ -18,10 +18,11 @@ properties:
   compatible:
     oneOf:
       - enum:
-          - samsung,exynos5433-mfc        # Exynos5433
-          - samsung,mfc-v5                # Exynos4
+          - samsung,s5pv210-mfc           # S5pv210
+          - samsung,exynos4-mfc           # Exynos4
           - samsung,exynos5250-mfc        # Exynos5
           - samsung,exynos5420-mfc        # Exynos5420
+          - samsung,exynos5433-mfc        # Exynos5433
           - samsung,exynos5800-mfc        # Exynos5800
           - samsung,exynos7880-mfc        # Exynos7880
           - tesla,fsd-mfc                 # Tesla FSD
@@ -114,7 +115,8 @@ allOf:
         compatible:
           contains:
             enum:
-              - samsung,mfc-v5
+              - samsung,s5pv210-mfc
+              - samsung,exynos4-mfc
     then:
       properties:
         clocks:
@@ -184,7 +186,7 @@ examples:
     #include <dt-bindings/interrupt-controller/irq.h>
 
     codec@13400000 {
-        compatible = "samsung,mfc-v5";
+        compatible = "samsung,exynos4-mfc";
         reg = <0x13400000 0x10000>;
         interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
         power-domains = <&pd_mfc>;
-- 
2.49.0

Re: [PATCH 00/10] Use SoC-specific compatible string for Samsung MFC

[Krzysztof Kozlowski]

On 07/08/2025 05:24, Aakarsh Jain wrote:
> This patch series modifies the samsung MFC version compatible to
> SoC-specific compatible.

You CC-ed an address, which suggests you do not work on mainline kernel
or you do not use get_maintainers.pl/b4/patman. Please rebase and always
work on mainline or start using mentioned tools, so correct addresses
will be used.

This also might explain why you could not read current kernel
practices/docs?

Best regards,
Krzysztof