* [patch] silence sparse warning in fs/reiserfs/namei.c about using plain integer as NULL pointer
@ 2004-11-21 22:08 Jesper Juhl
2004-11-22 15:59 ` Hans Reiser
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2004-11-21 22:08 UTC (permalink / raw)
To: Hans Reiser; +Cc: lkml
Hi,
sparse complains about passing 0 to functions execting a pointer argument:
CHECK fs/reiserfs/namei.c
fs/reiserfs/namei.c:617:50: warning: Using plain integer as NULL pointer
Trivial patch to change it to pass NULL instead below.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
diff -up linux-2.6.10-rc2-bk6-orig/fs/reiserfs/namei.c linux-2.6.10-rc2-bk6/fs/reiserfs/namei.c
--- linux-2.6.10-rc2-bk6-orig/fs/reiserfs/namei.c 2004-11-17 01:20:16.000000000 +0100
+++ linux-2.6.10-rc2-bk6/fs/reiserfs/namei.c 2004-11-21 22:52:41.000000000 +0100
@@ -614,7 +614,7 @@ static int reiserfs_create (struct inode
goto out_failed;
}
- retval = reiserfs_new_inode (&th, dir, mode, 0, 0/*i_size*/, dentry, inode);
+ retval = reiserfs_new_inode (&th, dir, mode, NULL, 0/*i_size*/, dentry, inode);
if (retval)
goto out_failed;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] silence sparse warning in fs/reiserfs/namei.c about using plain integer as NULL pointer
2004-11-21 22:08 [patch] silence sparse warning in fs/reiserfs/namei.c about using plain integer as NULL pointer Jesper Juhl
@ 2004-11-22 15:59 ` Hans Reiser
0 siblings, 0 replies; 2+ messages in thread
From: Hans Reiser @ 2004-11-22 15:59 UTC (permalink / raw)
To: Jesper Juhl; +Cc: lkml, vs
Jesper Juhl wrote:
>Hi,
>
>sparse complains about passing 0 to functions execting a pointer argument:
>
> CHECK fs/reiserfs/namei.c
>fs/reiserfs/namei.c:617:50: warning: Using plain integer as NULL pointer
>
>Trivial patch to change it to pass NULL instead below.
>
>Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
>
>diff -up linux-2.6.10-rc2-bk6-orig/fs/reiserfs/namei.c linux-2.6.10-rc2-bk6/fs/reiserfs/namei.c
>--- linux-2.6.10-rc2-bk6-orig/fs/reiserfs/namei.c 2004-11-17 01:20:16.000000000 +0100
>+++ linux-2.6.10-rc2-bk6/fs/reiserfs/namei.c 2004-11-21 22:52:41.000000000 +0100
>@@ -614,7 +614,7 @@ static int reiserfs_create (struct inode
> goto out_failed;
> }
>
>- retval = reiserfs_new_inode (&th, dir, mode, 0, 0/*i_size*/, dentry, inode);
>+ retval = reiserfs_new_inode (&th, dir, mode, NULL, 0/*i_size*/, dentry, inode);
> if (retval)
> goto out_failed;
>
>
>
>
>
>
>
thanks, vs. will look into it and get back to you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-23 4:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-21 22:08 [patch] silence sparse warning in fs/reiserfs/namei.c about using plain integer as NULL pointer Jesper Juhl
2004-11-22 15:59 ` Hans Reiser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox