Re: [PATCH] Remove pointless <0 comparison for unsigned variable in fs/fcntl.c

Valdis.Kletnieks
2004-11-27T06:31:02Z

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

On Tue, 23 Nov 2004 17:03:10 CST, Timur Tabi said:
> Jesper Juhl wrote:
>
> > if pid_t is 16 bit, then the value can never be greater than 0xffff but,
> > if pid_t is greater than 16 bit, say 32 bit, then the argument "a" could
> > very well contain a value greater than 0xffff and then the comparison
> > makes perfect sense.
>
> If pid_t is 32-bit, then what's wrong with the value being greater than
> 0xFFFF? After all, if pid_t a 32-bit number, that implies that 32-bit
> values are acceptable.

Try setting max_pid to 256K or so on an i386 - although the result fits
nicely in a pid_t with plenty of bits to spare, Very Bad Things happen.

Long thread starting at http://marc.theaimsgroup.com/?l=linux-kernel&m=109497978724424&w=2

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]