From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>,
jgarzik@pobox.com, alan@redhat.com, david.balazic@hermes.si,
hpa@zytor.com, ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] EDD: add edd=off and edd=skipmbr options
Date: Tue, 23 Nov 2004 19:11:00 -0800 [thread overview]
Message-ID: <41A3FBC4.5030609@osdl.org> (raw)
In-Reply-To: <20041123230001.GE30452@lists.us.dell.com>
Matt Domsch wrote:
>
> Peter, Andi: I've built this for x86 and x86-64, and run this on x86.
> I'd appreciate your review of the assembly code, and suggestions for
> improvement, prior to my submitting it to akpm for 2.6.11.
>
> EDD: add edd=off and edd=skipmbr command line options
>
> New command line options
> edd=off (or edd=of)
> edd=skipmbr (or edd=sk)
>
> These are provided to allow Linux distributions to include CONFIG_EDD=m, yet
> allow end-users to disable parts of EDD which may not work well with their
> system's BIOS.
Sorry to nitpick this, but the doc. should include an
'=' sign like the ones before and after it:
edb= [HW,PS2]
+
+ edd [EDD]
+ Format: {"of[f]" | "sk[ipmbr]"}
+ See comment in arch/i386/boot/edd.S
in edd.S:
+ movb $0, (EDD_MBR_SIG_NR_BUF) # zero value at EDD_MBR_SIG_NR_BUF
+ movb $0, (EDDNR) # zero value at EDDNR
Such obvious comments aren't needed, even if they were just
moved from other places....
Rest of the .S code makes sense to me.
~Randy
next prev parent reply other threads:[~2004-11-24 3:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-23 23:00 [PATCH 2.6] EDD: add edd=off and edd=skipmbr options Matt Domsch
2004-11-24 3:11 ` Randy.Dunlap [this message]
2004-11-24 10:39 ` Andi Kleen
2004-12-02 19:25 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41A3FBC4.5030609@osdl.org \
--to=rddunlap@osdl.org \
--cc=Matt_Domsch@dell.com \
--cc=ak@suse.de \
--cc=alan@redhat.com \
--cc=c-d.hailfinger.kernel.2004@gmx.net \
--cc=david.balazic@hermes.si \
--cc=hpa@zytor.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox