Re: [PATCH] kdump: Fix for boot problems on SMP

Badari Pulavarty
2004-11-18T15:34:58Z

Hari,

Tested the patch on my 4-way P-III (where it was hanging earlier)
and it works fine for me.

Thanks,
Badari

Hariprasad Nellitheertha wrote:
> Hi Andrew,
>
> There was a buggy (and unnecessary) reserve_bootmem call in the kdump
> call which was causing hangs during early on some SMP machines. The
> attached patch removes that.
>
> Kindly include this patch into the -mm tree.
>
> Thanks and Regards, Hari
>
>
> ------------------------------------------------------------------------
>
>
>
> Signed-off-by: Hariprasad Nellitheertha <hari@in.ibm.com>
> ---
>
> linux-2.6.10-rc2-hari/include/asm-i386/crash_dump.h | 1 -
> 1 files changed, 1 deletion(-)
>
> diff -puN include/asm-i386/crash_dump.h~kdump-reserve-bootmem-fix include/asm-i386/crash_dump.h
> --- linux-2.6.10-rc2/include/asm-i386/crash_dump.h~kdump-reserve-bootmem-fix 2004-11-18 19:20:47.000000000 +0530
> +++ linux-2.6.10-rc2-hari/include/asm-i386/crash_dump.h 2004-11-18 19:21:03.000000000 +0530
> @@ -37,7 +37,6 @@ static inline void set_saved_max_pfn(voi
> static inline void crash_reserve_bootmem(void)
> {
> if (!dump_enabled) {
> - reserve_bootmem(0, CRASH_RELOCATE_SIZE);
> reserve_bootmem(CRASH_BACKUP_BASE,
> CRASH_BACKUP_SIZE + CRASH_RELOCATE_SIZE + PAGE_SIZE);
> }
> _