Re: Suspend 2 merge

Pavel Machek
2004-11-26T22:44:10Z

Hi!

> > > Again, when you're running on limited time, twice as fast is still twice
> > > as fast.
> >
> > My machine suspends in 7 seconds, and that's swsusp1. According to
> > your numbers, suspend2 should suspend it in 1 second and LZE
> > compressed should be .5 second.
> >
> > I'd say "who cares". 7 seconds seems like fast enough for me. And I'm
> > *not* going to add 2000 lines of code for 500msec speedup during
> > suspend.
>
> Yupp. Premature optimization is the roo of all evil. swsusp is
>
> a) an absolute slowpath compared to any normal kernel operation,
> and called extremly seldomly
> b) only usefull for a small subset of all linux instances
>
> hacking core code (fastpathes) for speedups there is a really bad idea.
> If you can speed it up without beeing intrusive all power to you.

I have to agree here. Swsusp is not really performance critical,
almost every other part of kernel is more important.

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!