Re: Suspend 2 merge

Christoph Hellwig
2004-11-24T14:09:54Z

On Wed, Nov 24, 2004 at 11:56:35PM +1100, Nigel Cunningham wrote:
> Hi everyone.
>
> I know that I still have work to do on suspend2, but thought it was high
> time I got around to properly submitting the code for review, so here
> goes.
>
> I have it split up into 51 patches, of which most are less than 20k,
> although there are three 50k patches. Changes to the rest of the kernel
> tree come first, then the core. The full tree can be found at

Your way of merging looks rather wrong. Please submit changes against the
current swsusp code that introduce one feature after another to bring it
at the level you want. You'll surely have to rewrok it a lot until all
reviewers are happy.

And most importantly for each patch explain exactly what feature it
implements and why, etc.. "swsusp2" tells exactly nothing about the
changed you do.