Re: Suspend 2 merge: 26/51: Kconfig and makefile.

Roman Zippel
2004-11-24T16:38:09Z

Hi,

On Wed, 24 Nov 2004, Nigel Cunningham wrote:

> +menu "Software Suspend 2"
> +
> +config SOFTWARE_SUSPEND2_CORE
> + tristate "Software Suspend 2"
> + depends on PM
> + select SOFTWARE_SUSPEND2
> + ---help---
> + Software Suspend 2 is the 'new and improved' suspend support. You
> + can now build it as modules, but be aware that this requires
> + initrd support (the modules you use in saving the image have to
> + be loaded in order for you to be able to resume!)
> +
> + See the Software Suspend home page (softwaresuspend.berlios.de)
> + for FAQs, HOWTOs and other documentation.
> +
> + config SOFTWARE_SUSPEND2
> + bool
> +
> + if SOFTWARE_SUSPEND2
> + config SOFTWARE_SUSPEND2_WRITER
> + bool
> +

Please don't use such indentations.
There is no need to use to select here either. If you really want to make
it modular (and you can convince Christoph), you want to do something like
this:

config SOFTWARE_SUSPEND2
tristate "Software Suspend 2"
depends on PM

config SOFTWARE_SUSPEND2_BUILTIN
def_bool SOFTWARE_SUSPEND2

and let everything else depend on SOFTWARE_SUSPEND2.

> + config SOFTWARE_SUSPEND_SWAPWRITER
> + tristate ' Swap Writer'
> + depends on SWAP && SOFTWARE_SUSPEND2_CORE
> + select SOFTWARE_SUSPEND2_WRITER

This select is also bogus.

> +
> +ifeq ($(CONFIG_SOFTWARE_SUSPEND2),y)
> +obj-y += suspend_builtin.o proc.o
> +endif

Use SOFTWARE_SUSPEND2_BUILTIN here without the ifeq.

bye, Roman