Re: Suspend 2 merge: 48/51: Swapwriter

Pavel Machek
2004-11-26T23:54:02Z

Hi!

> This is the swapwriter. It is forms the glue between the highlevel I/O
> routines in io.c and the blockwriter routines in block_io.c. It is
> responsible for allocating storage, translating the requests for pages
> within pagesets into devices and blocks and the like. It is abstracted
> from the block writer because the plan is that we'll eventually have a
> generic file writer (ie not using swapspace, but a simple file,
> possibly

This file alone is bigger than whole swsusp1. That strongly suggests
you have too many layers of abstraction in there. Planning for future
is nice, but not at this cost.

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!