From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Greg KH <greg@kroah.com>
Cc: Roland Dreier <roland@topspin.com>,
Gerrit Huizenga <gh@us.ibm.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org,
Rik van Riel <riel@redhat.com>, Chris Mason <mason@suse.com>,
ckrm-tech <ckrm-tech@lists.sourceforge.net>
Subject: Re: [PATCH] CKRM: 3/10 CKRM: Core ckrm, rcfs
Date: Mon, 29 Nov 2004 14:46:52 -0800 [thread overview]
Message-ID: <41ABA6DC.4090607@osdl.org> (raw)
In-Reply-To: <20041129223312.GA20667@kroah.com>
Greg KH wrote:
> On Mon, Nov 29, 2004 at 02:28:32PM -0800, Roland Dreier wrote:
>
>> Greg> Ick. Don't put a _t at the end of a typedef. Wrong OS
>> Greg> style guide.
>>
>>Just out of curiousity, who wrote the line
>>
>> typedef int __bitwise kobject_action_t;
>>
>>in <linux/kobject_uevent.h>? From the changelog it almost looks like
>>you did it ;)
>
>
> Yeah, at Linus's insistance. See his email about the whole __bitwise
> stuff for that :(
>
> But I did it for a simple variable type. Not a structure.
>
> /me justifies it to himself somehow...
And you are right to do so. Typedefs for base types make a lot of
sense. Just don't obfuscate structs with them.
--
~Randy
next prev parent reply other threads:[~2004-11-29 22:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 18:47 [PATCH] CKRM: 3/10 CKRM: Core ckrm, rcfs Gerrit Huizenga
2004-11-29 22:00 ` Greg KH
2004-11-29 22:28 ` Roland Dreier
2004-11-29 22:33 ` Greg KH
2004-11-29 22:46 ` Randy.Dunlap [this message]
2004-11-30 7:46 ` Arjan van de Ven
2005-02-24 9:33 ` Gerrit Huizenga
2005-02-24 17:52 ` Greg KH
2005-02-24 20:54 ` Gerrit Huizenga
2005-02-24 21:11 ` Greg KH
2005-02-24 21:30 ` Gerrit Huizenga
2005-02-24 22:53 ` Chandra Seetharaman
[not found] <200411292000.iATK0uuD003049@falcon10.austin.ibm.com>
2004-11-29 20:14 ` Gerrit Huizenga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ABA6DC.4090607@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=gh@us.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=riel@redhat.com \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox