From: Jeff Garzik <jgarzik@pobox.com>
To: Roger Luethi <rl@hellgate.ch>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Pavel Ruzicka <pavouk@pavouk.org>
Subject: Re: [PATCH 2.6] via-rhine: WOL band-aid
Date: Tue, 30 Nov 2004 18:17:52 -0500 [thread overview]
Message-ID: <41ACFFA0.2030904@pobox.com> (raw)
In-Reply-To: <20041130224014.GD29947@k3.hellgate.ch>
Roger Luethi wrote:
> After I disabled legacy WOL (i.e. controlled by EEPROM rather than
> driver) in 2.6.9, several people reported regressions. Legacy WOL had
> worked for them, but now it didn't anymore. The Right Way (TM) to fix
> this will get the driver to set up working WOL for all hardware, but a
> simpler solution will have to do for the time being: If a user requests
> magic packet WOL, the driver re-enables legacy WOL. Yeah, I know it's
> cheating.
>
> This version applies against -mm. I suggest to put it there for testing
> and into 2.6.11 if feedback is good.
>
> Thanks to Pavel Ruzicka for testing.
I don't object to the patch, but I wonder if anything can be done to
reduce the usage of "magic numbers" (numeric rather than named constants)?
Jeff
next prev parent reply other threads:[~2004-11-30 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 22:40 [PATCH 2.6] via-rhine: WOL band-aid Roger Luethi
2004-11-30 23:17 ` Jeff Garzik [this message]
2004-11-30 23:45 ` Roger Luethi
2004-12-02 22:40 ` Jeff Garzik
2004-12-01 0:46 ` [PATCH 2.6] via-rhine: WOL band-aid (patch against 2.6.9) Sven Ladegast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ACFFA0.2030904@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavouk@pavouk.org \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox