Re: Trouble with swiotlb

["Randy.Dunlap" <rddunlap@osdl.org>]

Roland Fehrenbacher wrote:
>>>>>>"Randy" == Randy Dunlap <Randy.Dunlap> writes:
> 
> 
>     Randy> Roland Fehrenbacher wrote:
>     >> Hi,
>     >> 
>     >> when building 2.4.28 or 2.4.27 on x86_64 with IOMMU and SWIOTLB
>     >> support enabled I get unresolved symbol for 3 modules:
>     >> 
>     >> depmod: *** Unresolved symbols in
>     >> /lib/modules/2.4.28/kernel/drivers/net/e1000/e1000.o depmod:
>     >> *** Unresolved symbols in
>     >> /lib/modules/2.4.28/kernel/drivers/usb/host/uhci.o depmod: ***
>     >> Unresolved symbols in
>     >> /lib/modules/2.4.28/kernel/drivers/usb/host/usb-uhci.o
>     >> 
>     >> When modprobing any of the modules I get: unresolved symbol
>     >> swiotlb
>     >> 
>     >> The kernel boots fine on Opterons and EM64T Xeons otherwise.
>     >> 
>     >> Any ideas.
> 
>     Randy> Looks like it just needs 'swiotlb' exported (as in 2.6.x).
>     Randy> Can you test the attached patch?  I don't have 2.4.x
>     Randy> booting on x8-64 yet.
> 
> Hi Randy,
> 
> thanks for the fast reply. Your patch solved the problem. I can boot
> Opterons and EM64T Xeons now without any problems.

Thanks for the results.  Marcelo, can you rip out my garbaged patch
header/description before applying it?   :)


> Roland
>  
> linux-2428-work
> <description>
> 
> Signed-off-by: Your Name <email@domain.tld>
> 
> diffstat:=
>  arch/x86_64/kernel/setup.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff -Naurp ./arch/x86_64/kernel/setup.c~swiotlb ./arch/x86_64/kernel/setup.c
> --- ./arch/x86_64/kernel/setup.c~swiotlb	2004-08-07 16:26:04.000000000 -0700
> +++ ./arch/x86_64/kernel/setup.c	2004-12-03 11:54:07.000000000 -0800
> @@ -52,6 +52,7 @@ int acpi_disabled;
>  EXPORT_SYMBOL(acpi_disabled);
>  
>  int swiotlb;
> +EXPORT_SYMBOL(swiotlb);
>  
>  extern	int phys_proc_id[NR_CPUS];


-- 
~Randy