From: matthieu castet <castet.matthieu@free.fr>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Adam Belay <ambx1@neo.rr.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
Date: Mon, 06 Dec 2004 01:46:54 +0100 [thread overview]
Message-ID: <41B3ABFE.5090105@free.fr> (raw)
In-Reply-To: <41B3A963.4090003@keyaccess.nl>
Rene Herman wrote:
> Hi Adam.
>
> Between 2.6.8 and 2.6.9, the following patch to rsparser.c was merged:
>
> http://linus.bkbits.net:8080/linux-2.5/cset@414703f7MEe33PTYY-aFQaM3CLKjZw?nav=index.html|src/|src/drivers|src/drivers/pnp|src/drivers/pnp/pnpbios|related/drivers/pnp/pnpbios/rsparser.c
>
>
> The added warning triggers on my machine:
>
> Linux Plug and Play Support v0.97 (c) Adam Belay
> PnPBIOS: Scanning system for PnP BIOS support...
> PnPBIOS: Found PnP BIOS installation structure at 0xc00f7740
> PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0x6634, dseg 0xf0000
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: 13 nodes reported by PnP BIOS; 13 recorded by driver
>
> I don't believe those warnings should be printed, what with "broken" the
> expected state of anything coming from the BIOS. The attached patch
> removes them again. Works for me...
>
> Rene.
>
>
>
>
>
>
> ------------------------------------------------------------------------
>
> --- linux-2.6.10-rc3.orig/drivers/pnp/pnpbios/rsparser.c 2004-12-04 03:10:03.000000000 +0100
> +++ linux-2.6.10-rc3/drivers/pnp/pnpbios/rsparser.c 2004-12-06 01:12:50.000000000 +0100
> @@ -433,14 +433,10 @@
> case SMALL_TAG_ENDDEP:
> if (len != 0)
> goto len_err;
> - if (option_independent == option)
> - printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_STARTDEP tag\n");
this one shouldn't be removed
> option = option_independent;
> break;
>
> case SMALL_TAG_END:
> - if (option_independent != option)
> - printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_ENDDEP tag\n");
ok for this one, may be change it to pnp_dbg(...)
> p = p + 2;
> return (unsigned char *)p;
> break;
Matthieu
next prev parent reply other threads:[~2004-12-06 0:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 0:35 [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag Rene Herman
2004-12-06 0:46 ` matthieu castet [this message]
2004-12-06 1:04 ` Rene Herman
2004-12-06 2:42 ` Adam Belay
2004-12-06 3:06 ` Rene Herman
2004-12-06 16:59 ` Adam Belay
2004-12-06 21:04 ` Rene Herman
2004-12-07 0:03 ` Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41B3ABFE.5090105@free.fr \
--to=castet.matthieu@free.fr \
--cc=ambx1@neo.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox