* [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
@ 2004-12-06 0:35 Rene Herman
2004-12-06 0:46 ` matthieu castet
2004-12-06 2:42 ` Adam Belay
0 siblings, 2 replies; 8+ messages in thread
From: Rene Herman @ 2004-12-06 0:35 UTC (permalink / raw)
To: Adam Belay; +Cc: Matthieu Castet, Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
Hi Adam.
Between 2.6.8 and 2.6.9, the following patch to rsparser.c was merged:
http://linus.bkbits.net:8080/linux-2.5/cset@414703f7MEe33PTYY-aFQaM3CLKjZw?nav=index.html|src/|src/drivers|src/drivers/pnp|src/drivers/pnp/pnpbios|related/drivers/pnp/pnpbios/rsparser.c
The added warning triggers on my machine:
Linux Plug and Play Support v0.97 (c) Adam Belay
PnPBIOS: Scanning system for PnP BIOS support...
PnPBIOS: Found PnP BIOS installation structure at 0xc00f7740
PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0x6634, dseg 0xf0000
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: 13 nodes reported by PnP BIOS; 13 recorded by driver
I don't believe those warnings should be printed, what with "broken" the
expected state of anything coming from the BIOS. The attached patch
removes them again. Works for me...
Rene.
[-- Attachment #2: linux-2.6.10-rc3_rsparser.diff --]
[-- Type: text/x-patch, Size: 615 bytes --]
--- linux-2.6.10-rc3.orig/drivers/pnp/pnpbios/rsparser.c 2004-12-04 03:10:03.000000000 +0100
+++ linux-2.6.10-rc3/drivers/pnp/pnpbios/rsparser.c 2004-12-06 01:12:50.000000000 +0100
@@ -433,14 +433,10 @@
case SMALL_TAG_ENDDEP:
if (len != 0)
goto len_err;
- if (option_independent == option)
- printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_STARTDEP tag\n");
option = option_independent;
break;
case SMALL_TAG_END:
- if (option_independent != option)
- printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_ENDDEP tag\n");
p = p + 2;
return (unsigned char *)p;
break;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
2004-12-06 0:35 [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag Rene Herman
@ 2004-12-06 0:46 ` matthieu castet
2004-12-06 1:04 ` Rene Herman
2004-12-06 2:42 ` Adam Belay
1 sibling, 1 reply; 8+ messages in thread
From: matthieu castet @ 2004-12-06 0:46 UTC (permalink / raw)
To: Rene Herman; +Cc: Adam Belay, Linux Kernel
Rene Herman wrote:
> Hi Adam.
>
> Between 2.6.8 and 2.6.9, the following patch to rsparser.c was merged:
>
> http://linus.bkbits.net:8080/linux-2.5/cset@414703f7MEe33PTYY-aFQaM3CLKjZw?nav=index.html|src/|src/drivers|src/drivers/pnp|src/drivers/pnp/pnpbios|related/drivers/pnp/pnpbios/rsparser.c
>
>
> The added warning triggers on my machine:
>
> Linux Plug and Play Support v0.97 (c) Adam Belay
> PnPBIOS: Scanning system for PnP BIOS support...
> PnPBIOS: Found PnP BIOS installation structure at 0xc00f7740
> PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0x6634, dseg 0xf0000
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: 13 nodes reported by PnP BIOS; 13 recorded by driver
>
> I don't believe those warnings should be printed, what with "broken" the
> expected state of anything coming from the BIOS. The attached patch
> removes them again. Works for me...
>
> Rene.
>
>
>
>
>
>
> ------------------------------------------------------------------------
>
> --- linux-2.6.10-rc3.orig/drivers/pnp/pnpbios/rsparser.c 2004-12-04 03:10:03.000000000 +0100
> +++ linux-2.6.10-rc3/drivers/pnp/pnpbios/rsparser.c 2004-12-06 01:12:50.000000000 +0100
> @@ -433,14 +433,10 @@
> case SMALL_TAG_ENDDEP:
> if (len != 0)
> goto len_err;
> - if (option_independent == option)
> - printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_STARTDEP tag\n");
this one shouldn't be removed
> option = option_independent;
> break;
>
> case SMALL_TAG_END:
> - if (option_independent != option)
> - printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_ENDDEP tag\n");
ok for this one, may be change it to pnp_dbg(...)
> p = p + 2;
> return (unsigned char *)p;
> break;
Matthieu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
2004-12-06 0:35 [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag Rene Herman
2004-12-06 0:46 ` matthieu castet
@ 2004-12-06 2:42 ` Adam Belay
2004-12-06 3:06 ` Rene Herman
1 sibling, 1 reply; 8+ messages in thread
From: Adam Belay @ 2004-12-06 2:42 UTC (permalink / raw)
To: Rene Herman; +Cc: Matthieu Castet, Linux Kernel
On Mon, Dec 06, 2004 at 01:35:47AM +0100, Rene Herman wrote:
> Hi Adam.
>
> Between 2.6.8 and 2.6.9, the following patch to rsparser.c was merged:
>
> http://linus.bkbits.net:8080/linux-2.5/cset@414703f7MEe33PTYY-aFQaM3CLKjZw?nav=index.html|src/|src/drivers|src/drivers/pnp|src/drivers/pnp/pnpbios|related/drivers/pnp/pnpbios/rsparser.c
>
> The added warning triggers on my machine:
>
> Linux Plug and Play Support v0.97 (c) Adam Belay
> PnPBIOS: Scanning system for PnP BIOS support...
> PnPBIOS: Found PnP BIOS installation structure at 0xc00f7740
> PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0x6634, dseg 0xf0000
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: Missing SMALL_TAG_ENDDEP tag
> PnPBIOS: 13 nodes reported by PnP BIOS; 13 recorded by driver
>
> I don't believe those warnings should be printed, what with "broken" the
> expected state of anything coming from the BIOS. The attached patch
> removes them again. Works for me...
>
> Rene.
Hi Rene,
Could you please send me "pnp.tar" from something like this:
mkdir /tmp/pnp; cp /proc/bus/pnp/[0-f][0-f] /tmp/pnp; tar -cf pnp.tar /tmp/pnp; rm -fR /tmp/pnp
make sure the pnpbios /proc interface is compiled into the kernel.
I'd like to look at the node data to see what's going on.
Thanks,
Adam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
2004-12-06 2:42 ` Adam Belay
@ 2004-12-06 3:06 ` Rene Herman
2004-12-06 16:59 ` Adam Belay
0 siblings, 1 reply; 8+ messages in thread
From: Rene Herman @ 2004-12-06 3:06 UTC (permalink / raw)
To: Adam Belay; +Cc: Matthieu Castet, Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 2322 bytes --]
Adam Belay wrote:
> Could you please send me "pnp.tar" from something like this:
>
> mkdir /tmp/pnp; cp /proc/bus/pnp/[0-f][0-f] /tmp/pnp; tar -cf pnp.tar /tmp/pnp; rm -fR /tmp/pnp
>
> make sure the pnpbios /proc interface is compiled into the kernel.
>
> I'd like to look at the node data to see what's going on.
Sure, attached. In case it's useful/easier, earlier I also booted with
debugging printks added to pnpbios_parse_resource_option_data, noting
the tag types encountered. This produced:
Linux Plug and Play Support v0.97 (c) Adam Belay
PnPBIOS: Scanning system for PnP BIOS support...
PnPBIOS: Found PnP BIOS installation structure at 0xc00f7740
PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0x6634, dseg 0xf0000
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_END
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_END
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_END
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_DMA
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_DMA
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_DMA
PnPBIOS: SMALL_TAG_END
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: SMALL_TAG_STARTDEP
PnPBIOS: SMALL_TAG_PORT
PnPBIOS: SMALL_TAG_IRQ
PnPBIOS: SMALL_TAG_DMA
PnPBIOS: SMALL_TAG_END
PnPBIOS: Missing SMALL_TAG_ENDDEP tag
PnPBIOS: SMALL_TAG_END
PnPBIOS: 13 nodes reported by PnP BIOS; 13 recorded by driver
Cheers,
Rene.
[-- Attachment #2: pnp.tar --]
[-- Type: application/x-tar, Size: 20480 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
2004-12-06 3:06 ` Rene Herman
@ 2004-12-06 16:59 ` Adam Belay
2004-12-06 21:04 ` Rene Herman
0 siblings, 1 reply; 8+ messages in thread
From: Adam Belay @ 2004-12-06 16:59 UTC (permalink / raw)
To: Rene Herman; +Cc: Matthieu Castet, Linux Kernel
On Mon, Dec 06, 2004 at 04:06:14AM +0100, Rene Herman wrote:
> Adam Belay wrote:
>
> >Could you please send me "pnp.tar" from something like this:
> >
> >mkdir /tmp/pnp; cp /proc/bus/pnp/[0-f][0-f] /tmp/pnp; tar -cf pnp.tar
> >/tmp/pnp; rm -fR /tmp/pnp
> >
> >make sure the pnpbios /proc interface is compiled into the kernel.
> >
> >I'd like to look at the node data to see what's going on.
>
> Sure, attached. In case it's useful/easier, earlier I also booted with
> debugging printks added to pnpbios_parse_resource_option_data, noting
> the tag types encountered. This produced:
>
I appreciate the additional information. I looked through the binary files
manually and confirmed that they are missing an end-dep tag. It should be
harmless however. I think the error message needs to be debug or it could
be removed.
Thanks,
Adam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
2004-12-06 16:59 ` Adam Belay
@ 2004-12-06 21:04 ` Rene Herman
2004-12-07 0:03 ` Adam Belay
0 siblings, 1 reply; 8+ messages in thread
From: Rene Herman @ 2004-12-06 21:04 UTC (permalink / raw)
To: Adam Belay; +Cc: Matthieu Castet, Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Adam Belay wrote:
> I appreciate the additional information. I looked through the binary files
> manually and confirmed that they are missing an end-dep tag. It should be
> harmless however. I think the error message needs to be debug or it could
> be removed.
As far as I'm concerned, making it debug is not too useful. I normally
have pnp debug enabled but not to debug my BIOS.
Hence attachment. Could you push it on yourself if you agree? Thanks...
Rene.
[-- Attachment #2: linux-2.6.10-rc3_rsparser2.diff --]
[-- Type: text/x-patch, Size: 481 bytes --]
--- linux-2.6.10-rc3.orig/drivers/pnp/pnpbios/rsparser.c 2004-12-04 03:10:03.000000000 +0100
+++ linux-2.6.10-rc3/drivers/pnp/pnpbios/rsparser.c 2004-12-06 01:59:44.000000000 +0100
@@ -439,11 +439,7 @@
break;
case SMALL_TAG_END:
- if (option_independent != option)
- printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_ENDDEP tag\n");
- p = p + 2;
- return (unsigned char *)p;
- break;
+ return p + 2;
default: /* an unkown tag */
len_err:
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
2004-12-06 21:04 ` Rene Herman
@ 2004-12-07 0:03 ` Adam Belay
0 siblings, 0 replies; 8+ messages in thread
From: Adam Belay @ 2004-12-07 0:03 UTC (permalink / raw)
To: Rene Herman; +Cc: Matthieu Castet, Linux Kernel
On Mon, Dec 06, 2004 at 10:04:29PM +0100, Rene Herman wrote:
> Adam Belay wrote:
>
> >I appreciate the additional information. I looked through the binary files
> >manually and confirmed that they are missing an end-dep tag. It should be
> >harmless however. I think the error message needs to be debug or it could
> >be removed.
>
> As far as I'm concerned, making it debug is not too useful. I normally
> have pnp debug enabled but not to debug my BIOS.
>
> Hence attachment. Could you push it on yourself if you agree? Thanks...
>
> Rene.
>
>
Even if there is a problematic usage of dep tags, the possible resource list
will reflect it, so I'm fine with removing the message. Thanks for the patch.
Adam
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2004-12-07 0:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-06 0:35 [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag Rene Herman
2004-12-06 0:46 ` matthieu castet
2004-12-06 1:04 ` Rene Herman
2004-12-06 2:42 ` Adam Belay
2004-12-06 3:06 ` Rene Herman
2004-12-06 16:59 ` Adam Belay
2004-12-06 21:04 ` Rene Herman
2004-12-07 0:03 ` Adam Belay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox