From: Chris Friesen <cfriesen@nortelnetworks.com>
To: Riina Kikas <riinak@ut.ee>
Cc: linux-kernel@vger.kernel.org, mroos@ut.ee
Subject: Re: [PATCH 2.6] clean-up: fixes "unsigned>=0" warning
Date: Mon, 06 Dec 2004 15:03:58 -0600 [thread overview]
Message-ID: <41B4C93E.10203@nortelnetworks.com> (raw)
In-Reply-To: <Pine.SOC.4.61.0412062247160.21075@math.ut.ee>
Riina Kikas wrote:
> This patch fixes warning "comparison of unsigned expression >= 0 is
> always true"
> occuring on line 38
>
> Signed-off-by: Riina Kikas <Riina.Kikas@mail.ee>
>
> --- a/fs/ntfs/collate.h 2004-10-18 21:53:06.000000000 +0000
> +++ b/fs/ntfs/collate.h 2004-12-04 13:26:03.000000000 +0000
> @@ -37,7 +37,7 @@
> if (unlikely(cr != COLLATION_BINARY && cr != COLLATION_NTOFS_ULONG))
> return FALSE;
> i = le32_to_cpu(cr);
> - if (likely(((i >= 0) && (i <= 0x02)) ||
> + if (likely(cr <= 0x02 ||
Do we really want to be doing any operations on "cr", since it's not known what
endianness of cpu we're on?
Chris
next prev parent reply other threads:[~2004-12-06 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 20:48 [PATCH 2.6] clean-up: fixes "unsigned>=0" warning Riina Kikas
2004-12-06 21:03 ` Chris Friesen [this message]
2004-12-06 21:25 ` Riina Kikas
-- strict thread matches above, loose matches on Subject: below --
2004-12-06 20:59 [PATCH 2.6] clean-up: fixes "unsigned<0" warning Riina Kikas
2004-12-06 20:47 Riina Kikas
2004-12-06 20:44 Riina Kikas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41B4C93E.10203@nortelnetworks.com \
--to=cfriesen@nortelnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@ut.ee \
--cc=riinak@ut.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox