From: Arne Caspari <arne@datafloater.de>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/base/driver.c : driver_unregister
Date: Sat, 11 Dec 2004 19:54:32 +0100 [thread overview]
Message-ID: <41BB4268.8020908@datafloater.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
Hi all,
I think the meaning of this patch is obvious: In driver_unregister, the
bus_remove_driver function call was called outside the driver unload
semaphore which should obviously protect it.
/Arne
[-- Attachment #2: driver_unregister.patch --]
[-- Type: text/x-patch, Size: 476 bytes --]
*** linux-2.6.9/drivers/base/driver.c Mon Oct 18 23:55:06 2004
--- kernel-source-2.6.9/drivers/base/driver.c Sat Dec 11 10:59:59 2004
***************
*** 106,113 ****
void driver_unregister(struct device_driver * drv)
{
- bus_remove_driver(drv);
down(&drv->unload_sem);
up(&drv->unload_sem);
}
--- 106,113 ----
void driver_unregister(struct device_driver * drv)
{
down(&drv->unload_sem);
+ bus_remove_driver(drv);
up(&drv->unload_sem);
}
next reply other threads:[~2004-12-11 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-11 18:54 Arne Caspari [this message]
2004-12-11 19:11 ` [PATCH] drivers/base/driver.c : driver_unregister Russell King
2004-12-11 19:24 ` Arne Caspari
2004-12-13 7:21 ` Arne Caspari
2004-12-13 21:07 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41BB4268.8020908@datafloater.de \
--to=arne@datafloater.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox