* [PATCH] 2.6.9 ide-probe and indentical old disks.
@ 2004-12-16 22:47 Paul Gortmaker
2004-12-16 23:31 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2004-12-16 22:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
It seems that some old disks don't have a serial number, but ide-probe
now compares serial numbers to determine if a slave disk is just a
ghost image of the primary. This breaks old hardware that has two
identical model disks which don't report serial numbers. The fix seems
as simple as checking for zero length serial numbers before comparing.
Signed-off-by: Paul Gortmaker <p_gortmaker@yahoo.com>
--- linux-386/drivers/ide/ide-probe.c~ Mon Oct 18 17:56:33 2004
+++ linux-386/drivers/ide/ide-probe.c Thu Dec 9 14:15:56 2004
@@ -740,6 +740,8 @@ static void probe_hwif(ide_hwif_t *hwif)
if (strcmp(hwif->drives[0].id->model, drive->id->model) == 0 &&
/* Don't do this for noprobe or non ATA */
strcmp(drive->id->model, "UNKNOWN") &&
+ /* Or for old drives without a serial # */
+ strlen(drive->id->serial_no) &&
/* And beware of confused Maxtor drives that go "M0000000000"
"The SN# is garbage in the ID block..." [Eric] */
strncmp(drive->id->serial_no, "M0000000000000000000", 20) &&
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.6.9 ide-probe and indentical old disks.
2004-12-16 22:47 [PATCH] 2.6.9 ide-probe and indentical old disks Paul Gortmaker
@ 2004-12-16 23:31 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2004-12-16 23:31 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Andrew Morton, Linux Kernel Mailing List
On Iau, 2004-12-16 at 22:47, Paul Gortmaker wrote:
> It seems that some old disks don't have a serial number, but ide-probe
> now compares serial numbers to determine if a slave disk is just a
> ghost image of the primary. This breaks old hardware that has two
> identical model disks which don't report serial numbers. The fix seems
> as simple as checking for zero length serial numbers before comparing.
Already fixed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-12-17 0:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-16 22:47 [PATCH] 2.6.9 ide-probe and indentical old disks Paul Gortmaker
2004-12-16 23:31 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox