From: Bill Davidsen <davidsen@tmr.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Gerd Knorr <kraxel@bytesex.org>,
video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] bttv-cards.c: #if 0 function bttv_reset_audio
Date: Fri, 17 Dec 2004 10:30:34 -0500 [thread overview]
Message-ID: <41C2FB9A.9030305@tmr.com> (raw)
In-Reply-To: <20041216221805.GU12937@stusta.de>
Adrian Bunk wrote:
> The function bttv_reset_audio in drivers/media/video/bttv-cards.c is
> completely unused.
Looking at the comments and some old posts on the topic, are you sure
this is the right fix? It is uncalled, and has been since 2.6.0 (oldest
thing I have handy), but I think the actual bug may be that someone
forget to call it, possibly from bttv_init_card2?
It would appear to not be needed because a reset clears it, but in the
event that resume starts working, it might be useful.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.10-rc3-mm1-full/drivers/media/video/bttv-cards.c.old 2004-12-16 22:20:07.000000000 +0100
> +++ linux-2.6.10-rc3-mm1-full/drivers/media/video/bttv-cards.c 2004-12-16 22:20:30.000000000 +0100
> @@ -2498,7 +2498,7 @@
> }
>
> /* ----------------------------------------------------------------------- */
> -
> +#if 0
> void bttv_reset_audio(struct bttv *btv)
> {
> /*
> @@ -2519,6 +2519,7 @@
> udelay(10);
> btwrite( 0, 0x058);
> }
> +#endif /* 0 */
>
> /* initialization part one -- before registering i2c bus */
> void __devinit bttv_init_card1(struct bttv *btv)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
-bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
last possible moment - but no longer" -me
prev parent reply other threads:[~2004-12-17 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 22:18 [2.6 patch] bttv-cards.c: #if 0 function bttv_reset_audio Adrian Bunk
2004-12-17 15:30 ` Bill Davidsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C2FB9A.9030305@tmr.com \
--to=davidsen@tmr.com \
--cc=bunk@stusta.de \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox