Re: [ANNOUNCE 1/7] Diskdump 1.0 Release

Takao Indoh
2004-12-01T01:00:38Z

On Tue, 30 Nov 2004 14:23:59 +1100, Rusty Russell wrote:

>On Mon, 2004-11-29 at 19:37 +0900, Takao Indoh wrote:
>> This is a patch for diskdump common layer.
>...
>
>> +static int fallback_on_err = 1;
>> +static int allow_risky_dumps = 1;
>> +static unsigned int block_order = 2;
>> +static int sample_rate = 8;
>> +module_param_named(fallback_on_err, fallback_on_err, bool, S_IRUGO|
>> S_IWUSR);
>> +module_param_named(allow_risky_dumps, allow_risky_dumps, bool, S_IRUGO|
>> S_IWUSR);
>> +module_param_named(block_order, block_order, uint, S_IRUGO|S_IWUSR);
>> +module_param_named(sample_rate, sample_rate, int, S_IRUGO|S_IWUSR);
>
>You can just use "module_param" here (and elsewhere in the patch), since
>the name is the same as the variable name.

I see, thanks!

Best Regards,
Takao Indoh