Re: Linux 2.6.9-ac16

Francois Romieu
2004-12-17T18:57:46Z

Arjan van de Ven <arjan@infradead.org> :
> On Thu, 2004-12-16 at 18:43 +0000, Alan Cox wrote:
> > o Acenic must use __devinitdata for hotplug (Alan Cox)
> > | based on an RH patch
[...]
> MODULE_PARM_DESC(tx_ratio, "AceNIC/3C985/GA620 ratio of NIC memory used
> for TX/RX descriptors (range 0-63)");
>
>
> -static char version[] __initdata =
> +static char version[] __devinitdata =
> "acenic.c: v0.92 08/05/2002 Jes Sorensen, linux-acenic@SunSITE.dk\n"
> "http://home.cern.ch/~jes/gige/acenic.html\n";
>
> you broke this one... :-)
> the version var *cannot* be initdata of any kind, since the ethtool
> ioctl uses the variable. End Of Story(tm)

Episode 2

Actually ethtool_drvinfo.get_drvinfo() does not use _this_ version var
in the acenic driver. Btw it would be waaaaay too long for the 32 bytes
allowed in the misc fields of struct ethtool_drvinfo) (I messed the
r8169 driver this way).

--
Ueimor