Re: Linux 2.6.9-ac16

Arjan van de Ven
2004-12-17T11:23:56Z

On Thu, 2004-12-16 at 18:43 +0000, Alan Cox wrote:
> o Acenic must use __devinitdata for hotplug (Alan Cox)
> | based on an RH patch

diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.9/drivers/net/acenic.c
linux-2.6.9/drivers/net/acenic.c
--- linux.vanilla-2.6.9/drivers/net/acenic.c 2004-10-20
23:16:54.000000000 +0100
+++ linux-2.6.9/drivers/net/acenic.c 2004-12-16 17:13:10.799818288
+0000
@@ -444,7 +444,7 @@
MODULE_PARM_DESC(tx_ratio, "AceNIC/3C985/GA620 ratio of NIC memory used
for TX/RX descriptors (range 0-63)");

-static char version[] __initdata =
+static char version[] __devinitdata =
"acenic.c: v0.92 08/05/2002 Jes Sorensen, linux-acenic@SunSITE.dk\n"
"
http://home.cern.ch/~jes/gige/acenic.html\n";

you broke this one... :-)
the version var *cannot* be initdata of any kind, since the ethtool
ioctl uses the variable. End Of Story(tm)