From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: David Brownell <david-b@pacbell.net>,
Greg Kroah-Hartman <greg@kroah.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] USB: fix Scheduling while atomic warning when resuming.
Date: Tue, 21 Dec 2004 22:48:42 -0500 [thread overview]
Message-ID: <41C8EE9A.9080707@pobox.com> (raw)
In-Reply-To: <200412220103.iBM13wS0002158@hera.kernel.org>
Linux Kernel Mailing List wrote:
> ChangeSet 1.2215, 2004/12/21 16:25:03-08:00, greg@kroah.com
>
> [PATCH] USB: fix Scheduling while atomic warning when resuming.
>
> This fixes a warning when resuming the USB EHCI host controller driver.
> diff -Nru a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> --- a/drivers/usb/host/ehci-hub.c 2004-12-21 17:04:09 -08:00
> +++ b/drivers/usb/host/ehci-hub.c 2004-12-21 17:04:09 -08:00
> @@ -122,7 +122,7 @@
> writel (temp, &ehci->regs->port_status [i]);
> }
> i = HCS_N_PORTS (ehci->hcs_params);
> - msleep (20);
> + mdelay (20);
> while (i--) {
> temp = readl (&ehci->regs->port_status [i]);
This is more than a little bit silly.
The entire resume function holds spin_lock_irq() for far longer than a
timer tick.
If we are going for a minimalist -rc patch, why not drop the lock,
sleep, then reacquire the lock?
This strikes me as a bad change, make in haste for -rc, that will get
quickly forgotten (and left as-is) once 2.6.10 is released.
Jeff
next parent reply other threads:[~2004-12-22 3:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200412220103.iBM13wS0002158@hera.kernel.org>
2004-12-22 3:48 ` Jeff Garzik [this message]
2004-12-22 4:22 ` [PATCH] USB: fix Scheduling while atomic warning when resuming David Brownell
2004-12-22 4:46 ` Jeff Garzik
2004-12-22 4:59 ` David Brownell
2004-12-22 5:27 ` Jeff Garzik
2004-12-22 11:59 ` Benjamin Herrenschmidt
2004-12-22 16:16 ` David Brownell
2004-12-22 16:35 ` Benjamin Herrenschmidt
2004-12-22 16:14 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C8EE9A.9080707@pobox.com \
--to=jgarzik@pobox.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox