From: Shailabh Nagar <nagar@watson.ibm.com>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: noop insert
Date: Thu, 23 Dec 2004 11:01:24 -0500 [thread overview]
Message-ID: <41CAEBD4.8030609@watson.ibm.com> (raw)
In noop-iosched.c (2.6.10-rc2),
void elevator_noop_add_request(request_queue_t *q, struct request *rq,
int where)
{
struct list_head *insert = q->queue_head.prev;
if (where == ELEVATOR_INSERT_FRONT)
insert = &q->queue_head;
list_add_tail(&rq->queuelist, &q->queue_head);
<snip>
shouldn't the insertion happen at insert instead of q->queue_head ?
-- Shailabh
next reply other threads:[~2004-12-23 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 16:01 Shailabh Nagar [this message]
2004-12-24 10:07 ` noop insert Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41CAEBD4.8030609@watson.ibm.com \
--to=nagar@watson.ibm.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox