public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Nelson <james4765@verizon.net>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
	David Howells <dhowells@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: printk loglevel policy?
Date: Thu, 30 Dec 2004 23:07:05 -0500	[thread overview]
Message-ID: <41D4D069.3020300@verizon.net> (raw)
In-Reply-To: <2cd57c9004123018203b7e38ef@mail.gmail.com>

Coywolf Qi Hunt wrote:
> Hi all, 
> 
> Recently, I've seen a lot of add loglevel to printk patches. 
> grep 'printk("' -r | wc shows me 2433. There are probably 2433 printk
> need to patch, is it?  What's this printk loglevel policy, all these
> printk calls need loglevel adjusted?  The default loglevel is
> KERN_WARNING.
> 
> 
> --coywolf

Not every printk() needs a loglevel.  For example:

	printk (KERN_WARN "blah...");

	some stuff...

	printk ("bleh...");

	more stuff...

	printk ("done\n");

is used in a lot of areas.

You'll also see:
#ifdef VERBOSE_DEBUG
#define FOO_DEBUG(a, b) printk ("%s: %s\n", a, b)
#else
#define FOO_DEBUG(a, b)
#endif

which is normally only used for debug builds.

The logging levels are, for the most part, common sense.  KERN_ERR for error 
conditions, KERN_INFO for informational (i. e. "driver just loaded", "new disk 
detected"), KERN_CRIT if your computer just caught on fire (!), and KERN_DEBUG for 
any kind of verbose printing.


  reply	other threads:[~2004-12-31  4:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-31  2:02 [patch] add loglevel to printk in fs/afs/cmservice.c Jesper Juhl
2004-12-31  2:20 ` printk loglevel policy? Coywolf Qi Hunt
2004-12-31  4:07   ` Jim Nelson [this message]
2004-12-31  4:34     ` Jesper Juhl
2005-01-02 14:36   ` Alan Cox
2005-01-02 19:01     ` Jim Nelson
2005-01-02 21:41       ` Randy.Dunlap
2005-01-03  3:17         ` Keith Owens
2005-01-03  3:52           ` Randy.Dunlap
2005-01-03  4:44             ` Jim Nelson
2005-01-04 10:46           ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41D4D069.3020300@verizon.net \
    --to=james4765@verizon.net \
    --cc=coywolf@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=james4765@gmail.com \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox