From: Josh Aas <josha@sgi.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] remove outdated/misleading CPU scheduler comments
Date: Fri, 31 Dec 2004 12:59:09 -0600 [thread overview]
Message-ID: <41D5A17D.6070606@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
This patch removes two outdated/misleading comments from the CPU scheduler.
1) The first comment removed is simply incorrect. The function it
comments on is not used for what the comments says it is anymore.
2) The second comment is a leftover from when the "if" block it comments
on contained a goto. It does not any more, and the comment doesn't make
sense.
There isn't really a reason to add different comments, though someone
might feel differently in the case of the second one. I'll leave adding
a comment to anybody who wants to - more important to just get rid of
them now.
Signed-off-by: Josh Aas <josha@sgi.com>
--
Josh Aas
Linux System Software
Silicon Graphics, Inc. (SGI)
[-- Attachment #2: sched_comments.patch --]
[-- Type: text/plain, Size: 829 bytes --]
--- a/kernel/sched.c Fri Dec 24 15:35:24 2004
+++ b/kernel/sched.c Fri Dec 31 12:28:09 2004
@@ -580,11 +580,6 @@ static void enqueue_task(struct task_str
p->array = array;
}
-/*
- * Used by the migration code - we pull tasks from the head of the
- * remote queue so we want these tasks to show up at the head of the
- * local queue:
- */
static inline void enqueue_task_head(struct task_struct *p, prio_array_t *array)
{
list_add(&p->run_list, array->queue + p->prio);
@@ -2585,10 +2580,7 @@ need_resched_nonpreemptible:
if (unlikely(current->flags & PF_DEAD))
current->state = EXIT_DEAD;
- /*
- * if entering off of a kernel preemption go straight
- * to picking the next task.
- */
+
switch_count = &prev->nivcsw;
if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
switch_count = &prev->nvcsw;
next reply other threads:[~2004-12-31 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-31 18:59 Josh Aas [this message]
2005-01-04 10:08 ` [PATCH] remove outdated/misleading CPU scheduler comments Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41D5A17D.6070606@sgi.com \
--to=josha@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox