[PATCH] remove outdated/misleading CPU scheduler comments

[PATCH] remove outdated/misleading CPU scheduler comments

[Josh Aas]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

This patch removes two outdated/misleading comments from the CPU scheduler.

1) The first comment removed is simply incorrect. The function it 
comments on is not used for what the comments says it is anymore.
2) The second comment is a leftover from when the "if" block it comments 
on contained a goto. It does not any more, and the comment doesn't make 
sense.

There isn't really a reason to add different comments, though someone 
might feel differently in the case of the second one. I'll leave adding 
a comment to anybody who wants to - more important to just get rid of 
them now.

Signed-off-by: Josh Aas <josha@sgi.com>

-- 
Josh Aas
Linux System Software
Silicon Graphics, Inc. (SGI)


[-- Attachment #2: sched_comments.patch --]
[-- Type: text/plain, Size: 829 bytes --]

--- a/kernel/sched.c	Fri Dec 24 15:35:24 2004
+++ b/kernel/sched.c	Fri Dec 31 12:28:09 2004
@@ -580,11 +580,6 @@ static void enqueue_task(struct task_str
 	p->array = array;
 }
 
-/*
- * Used by the migration code - we pull tasks from the head of the
- * remote queue so we want these tasks to show up at the head of the
- * local queue:
- */
 static inline void enqueue_task_head(struct task_struct *p, prio_array_t *array)
 {
 	list_add(&p->run_list, array->queue + p->prio);
@@ -2585,10 +2580,7 @@ need_resched_nonpreemptible:
 
 	if (unlikely(current->flags & PF_DEAD))
 		current->state = EXIT_DEAD;
-	/*
-	 * if entering off of a kernel preemption go straight
-	 * to picking the next task.
-	 */
+
 	switch_count = &prev->nivcsw;
 	if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
 		switch_count = &prev->nvcsw;

Re: [PATCH] remove outdated/misleading CPU scheduler comments

[Ingo Molnar]

* Josh Aas <josha@sgi.com> wrote:

> This patch removes two outdated/misleading comments from the CPU scheduler.

> Signed-off-by: Josh Aas <josha@sgi.com>

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo