public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Andrew Morton <akpm@osdl.org>
Cc: Russell King <rmk@arm.linux.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: drivers/mmc/wbsd.c
Date: Mon, 10 Jan 2005 10:17:02 +0100	[thread overview]
Message-ID: <41E2480E.6040207@drzeus.cx> (raw)
In-Reply-To: <20050105194709.590f780c.akpm@osdl.org>

Andrew Morton wrote:

>static inline void wbsd_kunmap_sg(struct wbsd_host* host)
>{
>	kunmap_atomic(host->cur_sg->page, KM_BIO_SRC_IRQ);
>}
>
>Guys, kunmap_atomic() takes a kernel virtual address (the value which
>kmap_atomic() returned).
>
>Passing it the address of a pageframe will have unpleasant results.
>  
>
Thanks. kunmap_atomic() just messes with the preemption stuff (on x86 at 
least) so it probably would have gone unnoticed for a while.
I've fixed it now and it will be included in the next patch set.

Rgds
Pierre


      reply	other threads:[~2005-01-10  9:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-06  3:47 drivers/mmc/wbsd.c Andrew Morton
2005-01-10  9:17 ` Pierre Ossman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41E2480E.6040207@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox