From: Randy Vinson <rvinson@mvista.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH][PPC32] Missing call to ioremap in pci_iomap()
Date: Wed, 12 Jan 2005 11:23:39 -0700 [thread overview]
Message-ID: <41E56B2B.1040407@mvista.com> (raw)
Greetings,
The PPC version of pci_iomap seems to be missing a call to ioremap.
This patch corrects that oversight and has been tested on a IBM PPC750FX
Eval board. Please apply. Thanks.
Signed-off-by Randy Vinson <rvinson@mvista.com>
===== arch/ppc/kernel/pci.c 1.48 vs edited =====
--- 1.48/arch/ppc/kernel/pci.c Wed Oct 20 01:37:05 2004
+++ edited/arch/ppc/kernel/pci.c Wed Jan 12 11:19:14 2005
@@ -1712,7 +1712,11 @@
if (flags & IORESOURCE_IO)
return ioport_map(start, len);
if (flags & IORESOURCE_MEM)
- return (void __iomem *) start;
+ /* Not checking IORESOURCE_CACHEABLE because PPC does
+ * not currently distinguish between ioremap and
+ * ioremap_nocache.
+ */
+ return ioremap(start, len);
/* What? */
return NULL;
}
next reply other threads:[~2005-01-12 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 18:23 Randy Vinson [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-24 21:46 [PATCH] ppc32: Missing call to ioremap in pci_iomap() Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E56B2B.1040407@mvista.com \
--to=rvinson@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox