* [PATCH][PPC32] Missing call to ioremap in pci_iomap()
@ 2005-01-12 18:23 Randy Vinson
0 siblings, 0 replies; 2+ messages in thread
From: Randy Vinson @ 2005-01-12 18:23 UTC (permalink / raw)
To: linux-kernel
Greetings,
The PPC version of pci_iomap seems to be missing a call to ioremap.
This patch corrects that oversight and has been tested on a IBM PPC750FX
Eval board. Please apply. Thanks.
Signed-off-by Randy Vinson <rvinson@mvista.com>
===== arch/ppc/kernel/pci.c 1.48 vs edited =====
--- 1.48/arch/ppc/kernel/pci.c Wed Oct 20 01:37:05 2004
+++ edited/arch/ppc/kernel/pci.c Wed Jan 12 11:19:14 2005
@@ -1712,7 +1712,11 @@
if (flags & IORESOURCE_IO)
return ioport_map(start, len);
if (flags & IORESOURCE_MEM)
- return (void __iomem *) start;
+ /* Not checking IORESOURCE_CACHEABLE because PPC does
+ * not currently distinguish between ioremap and
+ * ioremap_nocache.
+ */
+ return ioremap(start, len);
/* What? */
return NULL;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ppc32: Missing call to ioremap in pci_iomap()
@ 2005-01-24 21:46 Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2005-01-24 21:46 UTC (permalink / raw)
To: akpm; +Cc: linuxppc-embedded, rvinson, linuxppc-dev, linux-kernel
The PPC version of pci_iomap seems to be missing a call to ioremap. This
patch corrects that oversight and has been tested on a IBM PPC750FX Eval
board.
Signed-off-by Randy Vinson <rvinson@mvista.com>
Signed-off-by Kumar Gala <kumar.gala@freescale.com>
---
diff -Nru a/arch/ppc/kernel/pci.c b/arch/ppc/kernel/pci.c
--- a/arch/ppc/kernel/pci.c 2005-01-24 15:43:19 -06:00
+++ b/arch/ppc/kernel/pci.c 2005-01-24 15:43:19 -06:00
@@ -1712,7 +1712,11 @@
if (flags & IORESOURCE_IO)
return ioport_map(start, len);
if (flags & IORESOURCE_MEM)
- return (void __iomem *) start;
+ /* Not checking IORESOURCE_CACHEABLE because PPC does
+ * not currently distinguish between ioremap and
+ * ioremap_nocache.
+ */
+ return ioremap(start, len);
/* What? */
return NULL;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-24 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-12 18:23 [PATCH][PPC32] Missing call to ioremap in pci_iomap() Randy Vinson
-- strict thread matches above, loose matches on Subject: below --
2005-01-24 21:46 [PATCH] ppc32: " Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox