From: Max Krasnyansky <maxk@qualcomm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BK] TUN/TAP driver update and fixes for 2.6.BK
Date: Wed, 12 Jan 2005 15:50:52 -0800 [thread overview]
Message-ID: <41E5B7DC.8020301@qualcomm.com> (raw)
In-Reply-To: <41E5B077.8030300@pobox.com>
Jeff Garzik wrote:
> Non-technical comments:
>
> 1) Please send drivers/net patches to me and netdev@oss.sgi.com
Ok
> 2) Consider using the bk-make-sum script (in Documentation/BK-usage/) to
> generate your summary. This will add a "bk pull " prefix to your BK url
> particularly, making it even easier to cut-n-paste.
I do use bk-make-sum. A bit hacked version though which does not add
'bk pull' prefix. I'll put it back in if it's useful for folks.
> 3) Please include a patch in your submission so that list readers may
> review your changes, not just the BK users.
Anybody can go to bkbits.net and review them. I'd rather not send
patches along with BK stuff, unless that's a new rule or something :).
> Technical comments:
>
> 2) in your implementation of tun_get_drvinfo(), it may be nice to
> include the tun/tap interface number in info->bus_info, to differentiate
> between multiple tun interfaces or multiple tap interfaces.
>
> 3) You might consider moving tun_set_msglevel() completely inside
> TUN_DEBUG ifdef.
>
> 4) use of MODULE_VERSION() is recommended
Good points.
Thanks
Max
next prev parent reply other threads:[~2005-01-12 23:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 22:34 [BK] TUN/TAP driver update and fixes for 2.6.BK Max Krasnyansky
2005-01-12 23:01 ` Andrew Morton
2005-01-12 23:14 ` Jeff Garzik
2005-01-12 23:16 ` Max Krasnyansky
2005-01-12 23:26 ` Andrew Morton
2005-01-12 23:40 ` Max Krasnyansky
2005-01-12 23:19 ` Jeff Garzik
2005-01-12 23:50 ` Max Krasnyansky [this message]
2005-01-12 23:54 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E5B7DC.8020301@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox