* [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1
@ 2005-01-22 13:48 Matthias-Christian Ott
2005-01-22 14:23 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Matthias-Christian Ott @ 2005-01-22 13:48 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Dave Jones, cpufreq, H. Peter Anvin, Dominik Brodowski,
Zwane Mwaikambo, Arjan van de Ven, Linus Torvalds
The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as
the models 2&3, so the bit shift must be bigger.
Signed-off-by: Matthias-Christian Ott <matthias.christian@tiscali.de>
--- linux-bk/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c.orig
2005-01-21 13:55:37.000000000 +0100
+++ linux-bk/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c 2005-01-22
10:58:34.000000000 +0100
@@ -160,7 +160,14 @@
printk(KERN_DEBUG "speedstep-lib: couldn't detect FSB speed.
Please send an e-mail to <linux@brodo.de>\n");
/* Multiplier. */
- mult = msr_lo >> 24;
+ if (c->x86_model < 2)
+ {
+ mult = msr_lo >> 27;
+ }
+ else
+ {
+ mult = msr_lo >> 24;
+ }
dprintk("P4 - FSB %u kHz; Multiplier %u; Speed %u kHz\n", fsb,
mult, (fsb * mult));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1
2005-01-22 13:48 [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1 Matthias-Christian Ott
@ 2005-01-22 14:23 ` Arjan van de Ven
2005-01-22 14:32 ` Matthias-Christian Ott
0 siblings, 1 reply; 3+ messages in thread
From: Arjan van de Ven @ 2005-01-22 14:23 UTC (permalink / raw)
To: Matthias-Christian Ott
Cc: Linux Kernel Mailing List, Dave Jones, cpufreq, H. Peter Anvin,
Dominik Brodowski, Zwane Mwaikambo, Linus Torvalds
On Sat, Jan 22, 2005 at 02:48:52PM +0100, Matthias-Christian Ott wrote:
> The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as
> the models 2&3, so the bit shift must be bigger.
I would feel safer if this checked that it was actually a p4 as well...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1
2005-01-22 14:23 ` Arjan van de Ven
@ 2005-01-22 14:32 ` Matthias-Christian Ott
0 siblings, 0 replies; 3+ messages in thread
From: Matthias-Christian Ott @ 2005-01-22 14:32 UTC (permalink / raw)
To: Arjan van de Ven
Cc: Linux Kernel Mailing List, Dave Jones, cpufreq, H. Peter Anvin,
Dominik Brodowski, Zwane Mwaikambo, Linus Torvalds
Arjan van de Ven wrote:
>On Sat, Jan 22, 2005 at 02:48:52PM +0100, Matthias-Christian Ott wrote:
>
>
>>The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as
>>the models 2&3, so the bit shift must be bigger.
>>
>>
>
>I would feel safer if this checked that it was actually a p4 as well...
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
Hi!
If mean my CPU, it's a pentium4 model 1 and the patch is checked with it.
All other tests which check if it's a pentium4 are performed by other
instances of the cpufreq driver.
Matthias-Christian Ott
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-22 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-22 13:48 [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1 Matthias-Christian Ott
2005-01-22 14:23 ` Arjan van de Ven
2005-01-22 14:32 ` Matthias-Christian Ott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox