Re: memory leak in 2.6.11-rc2

["Randy.Dunlap" <rddunlap@osdl.org>]

Andrew Tridgell wrote:
> I've fixed up the problems I had with raid, and am now testing the
> recent xattr changes with dbench and nbench.
> 
> The problem I've hit now is a severe memory leak. I have applied the
> patch from Linus for the leak in free_pipe_info(), and still I'm
> leaking memory at the rate of about 100Mbyte/minute.
> 
> I've tested with both 2.6.11-rc2 and with 2.6.11-rc1-mm2, both with
> the pipe leak fix. The setup is:
> 
>  - 4 way PIII with 4G ram
>  - qla2200 adapter with ibm fastt200 disk array 
>  - running dbench -x and nbench on separate disks, in a loop
> 
> The oom killer kicks in after about 30 minutes. Naturally the oom
> killer decided to kill my sshd, which was running vmstat :-) 

Do you have today's memleak patch applied?  (cut-n-paste below).

-- 
~Randy


----
--- 1.40/fs/pipe.c	2005-01-15 12:01:16 -08:00
+++ edited/fs/pipe.c	2005-01-24 14:35:09 -08:00
@@ -630,13 +630,13 @@
  	struct pipe_inode_info *info = inode->i_pipe;

  	inode->i_pipe = NULL;
-	if (info->tmp_page)
-		__free_page(info->tmp_page);
  	for (i = 0; i < PIPE_BUFFERS; i++) {
  		struct pipe_buffer *buf = info->bufs + i;
  		if (buf->ops)
  			buf->ops->release(info, buf);
  	}
+	if (info->tmp_page)
+		__free_page(info->tmp_page);
  	kfree(info);
  }

-