-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Greg KH wrote: > On Mon, Jan 24, 2005 at 07:25:19PM +0100, Jirka Kosina wrote: > >>Hi, >> >>there has been (for quite some time) a bug in function driver_unregister() >>- the lock/unlock sequence is protecting nothing and the actual >>bus_remove_driver() is called outside critical section. >> >>Please apply. > > > No, please read the comment in the code about why this is the way it is. > The code is correct as is. > Why don't we clean this up as in the proposed attached patch (against 2.6.10). Compile-tested only. - -- Mike Waychison Sun Microsystems, Inc. 1 (650) 352-5299 voice 1 (416) 202-8336 voice ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOTICE: The opinions expressed in this email are held by me, and may not represent the views of Sun Microsystems, Inc. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFB9fYjdQs4kOxk3/MRAgzrAJ96+aEawx/A0Sf0d5HqArsasgYrqQCZAVzp wuGctEJpxqtxezPD7LNGS+U= =77WW -----END PGP SIGNATURE-----