From: Zach Brown <zach.brown@oracle.com>
To: linux-kernel@vger.kernel.org
Subject: __getblk() spinning when size != bdev->...i_blkbits
Date: Thu, 27 Jan 2005 13:37:54 -0800 [thread overview]
Message-ID: <41F95F32.8000103@oracle.com> (raw)
Recently I debugged something that was spinning in the for(;;) in
__getblk_slow(). It turned out it was calling __getblk() with a size
argument that didn't match the bdev's inode's i_blkbits.
grow_buffers() would add a page at the index calculated from the 4k size
argument but when __getblk_slow() got back around to looking for the
instantiated page __find_get_block_slow() would look at the index
calculated from the 1k i_blkbits and not find the new page. Round and
round she goes.
If the different size inputs are intentional, would a simple BUG_ON() be
acceptible so that we can tell straight away if the caller messed up?
- z
reply other threads:[~2005-01-27 21:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41F95F32.8000103@oracle.com \
--to=zach.brown@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox