From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261214AbVAaO01 (ORCPT ); Mon, 31 Jan 2005 09:26:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261215AbVAaO01 (ORCPT ); Mon, 31 Jan 2005 09:26:27 -0500 Received: from mail.suse.de ([195.135.220.2]:4532 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S261214AbVAaO0X (ORCPT ); Mon, 31 Jan 2005 09:26:23 -0500 Message-ID: <41FE400E.7050604@suse.de> Date: Mon, 31 Jan 2005 15:26:22 +0100 From: Hannes Reinecke Organization: SuSE Linux AG User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.2) Gecko/20040906 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Matthew Garrett Cc: Pavel Machek , Linux Kernel Subject: Re: [PATCH] Resume from initramfs References: <41FE24F5.5070906@suse.de> <20050131125110.GD6279@elf.ucw.cz> <41FE3C34.4000200@suse.de> <1107181117.9518.2.camel@elrond.flymine.org> In-Reply-To: <1107181117.9518.2.camel@elrond.flymine.org> X-Enigmail-Version: 0.86.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Matthew Garrett wrote: > On Mon, 2005-01-31 at 15:09 +0100, Hannes Reinecke wrote: > > >>swsusp_check is used by both entry points, and is itself not a init >>function. >>I simply found it bad style to reference a __init function from there. >>And name_to_dev_t is evil in itself. I'd gladly be rid of it if possible. > > > name_to_dev_t won't work once userspace has started - you need to > set_fs(KERNEL_DS) at least one of the calls in it, IIRC. > I'm not advocating to use it. But referencing a non-existing function is just plain evil. We should better seperate both entry points to do the necessary device resolution themselves before calling generic functions. Cheers, Hannes -- Dr. Hannes Reinecke hare@suse.de SuSE Linux AG S390 & zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de