From: "Mark A. Greer" <mgreer@mvista.com>
To: Greg KH <greg@kroah.com>
Cc: phil@netroedge.com, sensors@stimpy.netroedge.com,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][I2C] Marvell mv64xxx i2c driver
Date: Mon, 31 Jan 2005 11:41:28 -0700 [thread overview]
Message-ID: <41FE7BD8.9060103@mvista.com> (raw)
In-Reply-To: <20050131182542.GB21438@kroah.com>
Greg KH wrote:
>On Tue, Jan 25, 2005 at 06:26:45PM -0700, Mark A. Greer wrote:
>
>
>>+static inline void
>>+mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status)
>>
>>
>
>This is a much too big of a function to be "inline". Please change it.
>Same for your other inline functions, that's not really needed, right?
>
>
>
>>+{
>>+ pr_debug("mv64xxx_i2c_fsm: ENTER--state: %d, status: 0x%x\n",
>>+ drv_data->state, status);
>>
>>
>
>Please use the dev_* calls instead. It gives you an accurate
>description of the specific device that emits the messages. Also use it
>for all of the printk() calls in the driver too.
>
>thanks,
>
>greg k-h
>
Certainly. I already posted this [incremental] patch based on your
previous comments,
http://www.ussg.iu.edu/hypermail/linux/kernel/0501.3/0941.html. Is that
better?
Mark
next prev parent reply other threads:[~2005-01-31 18:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-26 1:26 [PATCH][I2C] Marvell mv64xxx i2c driver Mark A. Greer
2005-01-26 19:56 ` Jean Delvare
2005-01-26 20:33 ` Mark A. Greer
2005-01-26 21:56 ` Mark A. Greer
2005-01-26 22:42 ` Greg KH
2005-01-26 23:59 ` Mark A. Greer
2005-01-31 18:25 ` Greg KH
2005-01-31 18:41 ` Mark A. Greer [this message]
2005-02-01 0:46 ` Greg KH
2005-02-01 17:54 ` Mark A. Greer
[not found] <200502020315.14281.adobriyan@mail.ru>
2005-02-02 1:27 ` Greg KH
2005-02-02 17:26 ` Mark A. Greer
[not found] ` <200502031556.59319.adobriyan@mail.ru>
2005-02-03 19:12 ` Mark A. Greer
2005-02-04 0:38 ` Alexey Dobriyan
2005-02-04 0:04 ` Mark A. Greer
2005-02-04 9:45 ` Jean Delvare
2005-02-06 14:36 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2005-02-08 23:27 Mark A. Greer
2005-02-09 0:01 ` Bartlomiej Zolnierkiewicz
2005-02-09 0:32 ` Mark A. Greer
2005-02-09 1:24 ` Bartlomiej Zolnierkiewicz
2005-02-09 21:33 ` Mark A. Greer
2005-02-17 22:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FE7BD8.9060103@mvista.com \
--to=mgreer@mvista.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@netroedge.com \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox