public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Con Kolivas <kernel@kolivas.org>
To: "Jack O'Quin" <joq@io.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	Alexander Nyberg <alexn@dsv.su.se>,
	Zwane Mwaikambo <zwane@linuxpower.ca>
Subject: Re: [PATCH] sched - Implement priority and fifo support for SCHED_ISO
Date: Tue, 01 Feb 2005 07:30:58 +1100	[thread overview]
Message-ID: <41FE9582.7090003@kolivas.org> (raw)
In-Reply-To: <87acqpjuoy.fsf@sulphur.joq.us>


[-- Attachment #1.1: Type: text/plain, Size: 383 bytes --]

Jack O'Quin wrote:
> Loading the realtime-lsm and then running with SCHED_FIFO *does* work
> as expected on this kernel.  I should retry the test with *exactly*
> the expected patch sequence.  What would that be?

Sure enough I found the bug in less than 5 mins, and it would definitely 
cause this terrible behaviour.

A silly bracket transposition error on my part :P

Cheers,
Con

[-- Attachment #1.2: iso_preempt_fix.diff --]
[-- Type: text/x-diff, Size: 472 bytes --]

Index: linux-2.6.11-rc2-iso/kernel/sched.c
===================================================================
--- linux-2.6.11-rc2-iso.orig/kernel/sched.c	2005-02-01 07:28:40.171079813 +1100
+++ linux-2.6.11-rc2-iso/kernel/sched.c	2005-02-01 07:29:21.332297160 +1100
@@ -326,9 +326,9 @@ static int task_preempts_curr(task_t *p,
 				goto out;
 			}
 			p_prio = ISO_PRIO;
+		}
 		if (iso_task(rq->curr))
 			curr_prio = ISO_PRIO;
-		}
 	}
 out:
 	if (p_prio < curr_prio)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

  parent reply	other threads:[~2005-01-31 20:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-26  9:47 [PATCH] sched - Implement priority and fifo support for SCHED_ISO Con Kolivas
2005-01-31 18:54 ` Jack O'Quin
2005-01-31 20:15   ` Con Kolivas
2005-01-31 20:30   ` Con Kolivas [this message]
2005-01-31 21:04     ` Jack O'Quin
2005-01-31 22:51     ` Jack O'Quin
2005-01-31 23:01       ` Con Kolivas
2005-02-01  2:27         ` Jack O'Quin
2005-02-01  2:46           ` Con Kolivas
2005-02-01  4:44             ` Jack O'Quin
2005-02-01  4:56               ` Con Kolivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41FE9582.7090003@kolivas.org \
    --to=kernel@kolivas.org \
    --cc=akpm@osdl.org \
    --cc=alexn@dsv.su.se \
    --cc=joq@io.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=zwane@linuxpower.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox