From: Karim Yaghmour <karim@opersys.com>
To: Greg KH <greg@kroah.com>
Cc: Tom Zanussi <zanussi@us.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>,
Roman Zippel <zippel@linux-m68k.org>,
Robert Wisniewski <bob@watson.ibm.com>,
Tim Bird <tim.bird@AM.SONY.COM>
Subject: Re: [PATCH] relayfs redux, part 2
Date: Mon, 31 Jan 2005 17:10:27 -0500 [thread overview]
Message-ID: <41FEACD3.10502@opersys.com> (raw)
In-Reply-To: <20050129081527.GD7738@kroah.com>
Greg KH wrote:
> On Fri, Jan 28, 2005 at 01:38:22PM -0600, Tom Zanussi wrote:
>
>>+extern void * alloc_rchan_buf(unsigned long size,
>>+ struct page ***page_array,
>>+ int *page_count);
>>+extern void free_rchan_buf(void *buf,
>>+ struct page **page_array,
>>+ int page_count);
>
>
> As these will be "polluting" the global namespace of the kernel, could
> you add "relayfs_" to the front of them?
BTW, these functions are in buffers.h which is an internal header to
fs/relayfs/*.c files. buffers.h is not included in anything outside.
Correct me if I'm wrong, but there is no namespace pollution in that
case, right? All that does contribute to namespace pollution is in
include/linux/relayfs_fs.h.
Thanks,
Karim
--
Author, Speaker, Developer, Consultant
Pushing Embedded and Real-Time Linux Systems Beyond the Limits
http://www.opersys.com || karim@opersys.com || 1-866-677-4546
next prev parent reply other threads:[~2005-01-31 22:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 19:38 [PATCH] relayfs redux, part 2 Tom Zanussi
2005-01-28 20:48 ` Tim Bird
2005-01-28 22:24 ` Andrew Morton
2005-01-29 8:08 ` Andi Kleen
2005-01-30 4:58 ` Tom Zanussi
2005-01-31 12:57 ` Andi Kleen
2005-01-31 16:26 ` Tom Zanussi
2005-01-31 19:41 ` Karim Yaghmour
2005-01-31 21:03 ` Tom Zanussi
2005-01-31 21:12 ` Karim Yaghmour
2005-01-31 19:38 ` Karim Yaghmour
2005-01-29 8:15 ` Greg KH
2005-01-30 5:02 ` Tom Zanussi
2005-01-31 22:10 ` Karim Yaghmour [this message]
2005-01-31 22:33 ` Greg KH
2005-01-31 22:35 ` Karim Yaghmour
2005-01-31 23:12 ` Roman Zippel
2005-02-01 15:44 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FEACD3.10502@opersys.com \
--to=karim@opersys.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=bob@watson.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@AM.SONY.COM \
--cc=zanussi@us.ibm.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox