From: Paul Moore <paul@paul-moore.com>
To: Luo Gengkun <luogengkun@huaweicloud.com>, peterz@infradead.org
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
will@kernel.org, jmorris@namei.org, serge@hallyn.com,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, stephen.smalley.work@gmail.com,
omosnace@redhat.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-security-module@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, selinux@vger.kernel.org,
luogengkun@huaweicloud.com
Subject: Re: [PATCH 1/2] perf: Remove unnecessary parameter of security check
Date: Wed, 26 Feb 2025 14:13:56 -0500 [thread overview]
Message-ID: <41cb98ddf724ade0fc529b8c952f3efc@paul-moore.com> (raw)
In-Reply-To: <20241223070650.2810747-2-luogengkun@huaweicloud.com>
On Dec 23, 2024 Luo Gengkun <luogengkun@huaweicloud.com> wrote:
>
> It seems that the attr parameter was never been used in security
> checks since it was first introduced by:
>
> commit da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
>
> so remove it.
>
> Signed-off-by: Luo Gengkun <luogengkun@huaweicloud.com>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
> ---
> arch/x86/events/intel/bts.c | 2 +-
> arch/x86/events/intel/core.c | 2 +-
> arch/x86/events/intel/p4.c | 2 +-
> drivers/perf/arm_spe_pmu.c | 4 ++--
> include/linux/lsm_hook_defs.h | 2 +-
> include/linux/perf_event.h | 10 +++++-----
> include/linux/security.h | 5 ++---
> kernel/events/core.c | 14 +++++++-------
> kernel/trace/trace_event_perf.c | 4 ++--
> security/security.c | 5 ++---
> security/selinux/hooks.c | 2 +-
> 11 files changed, 25 insertions(+), 27 deletions(-)
Now that we have Ingo's Reviewed-by, I've gone ahead and merged
patch 1/2 into lsm/dev, thanks everyone!
--
paul-moore.com
next prev parent reply other threads:[~2025-02-26 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 7:06 [PATCH linux-next 0/2] Fix perf security check problem Luo Gengkun
2024-12-23 7:06 ` [PATCH linux-next 1/2] perf: Remove unnecessary parameter of security check Luo Gengkun
2025-01-05 2:45 ` Paul Moore
2025-01-07 1:52 ` Luo Gengkun
2025-02-25 21:59 ` Ingo Molnar
2025-02-26 19:13 ` Paul Moore [this message]
2024-12-23 7:06 ` [PATCH linux-next 2/2] perf: Return EACCESS when need perfmon capability Luo Gengkun
2025-01-06 15:59 ` James Clark
2025-01-07 1:46 ` Luo Gengkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41cb98ddf724ade0fc529b8c952f3efc@paul-moore.com \
--to=paul@paul-moore.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jmorris@namei.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luogengkun@huaweicloud.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=omosnace@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox