Re: [PATCH 7/8] arm64: dts: qcom: x1e80100-qcp: Add power supply and sideband signal for pcie3

Krzysztof Kozlowski
2024-08-27T11:41:22Z

On Mon, Aug 26, 2024 at 11:36:30PM -0700, Qiang Yu wrote:
> Add perst, wake and clkreq gpio config. Add required power supply.
>
> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 116 ++++++++++++++++++++++
> 1 file changed, 116 insertions(+)
>

Really, driver cannot depend on this patch. That's a no go.

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> index 1c3a6a7b3ed6..0deb0c4bfea9 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> @@ -254,6 +254,48 @@ vreg_nvme: regulator-nvme {
> pinctrl-names = "default";
> pinctrl-0 = <&nvme_reg_en>;
> };
> +
> + vreg_pcie_12v: regulator-pcie_12v {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "VREG_PCIE_12V";
> + regulator-min-microvolt = <12000000>;
> + regulator-max-microvolt = <12000000>;
> +
> + gpio = <&pm8550ve_8_gpios 8 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie_x8_12v>;
> + };
> +
> + vreg_pcie_3v3_aux: regulator-pcie_3v3_aux {

Please follow DTS coding style.

> + compatible = "regulator-fixed";
> +
> + regulator-name = "VREG_PCIE_3P3_AUX";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&pmc8380_3_gpios 8 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pm_sde7_aux_3p3_en>;
> + };
> +
> + vreg_pcie_3v3: regulator-pcie_3v3 {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "VREG_PCIE_3P3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&pmc8380_3_gpios 6 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pm_sde7_main_3p3_en>;
> + };
> };
>
> &apps_rsc {
> @@ -667,6 +709,57 @@ &mdss_dp3_phy {
> status = "okay";
> };
>
> +&pm8550ve_8_gpios {
> + pcie_x8_12v: pcie_x8_12v_on {

Never tested.

Best regards,
Krzysztof