From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linlin Zhang <linlin.zhang@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, ebiggers@google.com
Cc: neeraj.soni@oss.qualcomm.com, gaurav.kashyap@oss.qualcomm.com,
deepti.jaggi@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com,
quic_shazhuss@quicinc.com, trilok.soni@oss.qualcomm.com,
konrad.dybcio@oss.qualcomm.com
Subject: Re: [PATCH v6 1/3] dt-bindings: crypto: qcom,ice: Add sa8255p support
Date: Thu, 30 Apr 2026 08:13:20 +0200 [thread overview]
Message-ID: <41da4b77-4d0d-48bd-9578-2adefe5466af@kernel.org> (raw)
In-Reply-To: <20260430032136.3058773-2-linlin.zhang@oss.qualcomm.com>
On 30/04/2026 05:21, Linlin Zhang wrote:
> On sa8255p, resources such as PHY, clocks, regulators, and resets are
> managed by remote firmware via the SCMI power protocol. As a result, the
> ICE driver cannot directly access clocks and must instead use power-domains
> to request resource configuration.
>
> Add the qcom,sa8255p-inline-crypto-engine compatible string and make clocks
> optional for platforms that use power-domains instead.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-30 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 3:21 [PATCH v6 0/3] soc: qcom: ice: Enable firmware managed resource Linlin Zhang
2026-04-30 3:21 ` [PATCH v6 1/3] dt-bindings: crypto: qcom,ice: Add sa8255p support Linlin Zhang
2026-04-30 6:13 ` Krzysztof Kozlowski [this message]
2026-04-30 3:21 ` [PATCH v6 2/3] soc: qcom: ice: Enable PM runtime for ICE driver Linlin Zhang
2026-04-30 3:21 ` [PATCH v6 3/3] soc: qcom: ice: Add SCMI support for sa8255p based targets Linlin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41da4b77-4d0d-48bd-9578-2adefe5466af@kernel.org \
--to=krzk@kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=deepti.jaggi@oss.qualcomm.com \
--cc=ebiggers@google.com \
--cc=gaurav.kashyap@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linlin.zhang@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=quic_shazhuss@quicinc.com \
--cc=trilok.soni@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox