From: Vasily Averin <vvs@sw.ru>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
Andrey Melnikov <temnota+kernel@kmv.ru>,
linux-kernel@vger.kernel.org, Atul Mukker <Atul.Mukker@lsil.com>,
Sreenivas Bagalkote <Sreenivas.Bagalkote@lsil.com>
Subject: Re: [PATCH] Prevent NMI oopser
Date: Wed, 02 Feb 2005 22:50:34 +0300 [thread overview]
Message-ID: <42012F0A.7080704@sw.ru> (raw)
In-Reply-To: <20050202190626.GB18763@lists.us.dell.com>
Matt Domsch wrote:
> On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote:
>>This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible
>>version that I've seen), taken from latest RHEL3 kernel update. I
>>believe it should prevent NMI in abort/reset handler.
>
> Thanks Vasily, I was just looking at this again yesterday.
>
> You'll also find that because the driver doesn't define its inline
> functions prior to their use, newest compilers refuse to compile this
> version of the driver. Earlier compilers just ignore it and don't
> inline anything.
>
> As a hack, one could #define inline /*nothing*/ in megaraid2.h to
> avoid this, but it would be nice if the functions could all get
> reordered such that inlining works properly, and the need for function
> declarations in megaraid2.h would disappear completely.
Could you fix it by additional fix? Or you going to release new driver
version for 2.4 kernels?
Thank you,
Vasily Averin
next prev parent reply other threads:[~2005-02-02 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41F5FC96.2010103@sw.ru>
2005-01-31 23:17 ` [PATCH] Prevent NMI oopser Marcelo Tosatti
2005-02-02 18:42 ` Vasily Averin
2005-02-02 18:53 ` Andrey J. Melnikoff (TEMHOTA)
2005-02-02 19:06 ` Matt Domsch
2005-02-02 19:32 ` Vasily Averin
2005-02-02 20:19 ` Matt Domsch
2005-02-02 21:08 ` Andrey J. Melnikoff (TEMHOTA)
[not found] ` <20050207202745.GA19104@kmv.ru>
2005-02-23 7:06 ` v2.4 megaraid2 update " Marcelo Tosatti
2005-02-02 19:39 ` Vasily Averin
2005-02-02 19:50 ` Vasily Averin [this message]
2005-01-25 7:47 Vasily Averin
2005-01-25 9:35 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42012F0A.7080704@sw.ru \
--to=vvs@sw.ru \
--cc=Atul.Mukker@lsil.com \
--cc=Matt_Domsch@dell.com \
--cc=Sreenivas.Bagalkote@lsil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=temnota+kernel@kmv.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox