In arch/i386/kernel/pci-irq.c:pcibios_enable_irq(), there is a redundant 
check:

     if (pin && !pcibios_lookup_irq(dev, 1) && !dev->irq) {

	/* ... */

         if (pin) {


We don't need the second 'if (pin)', as we already know it's nonzero 
from the first check.  Also note that this fixes the following warning 
(which happens because gcc's isn't always perfect with determining 
whether a variable is used uninitialized):

pci-irq.c: In function `pcibios_enable_irq':
pci-irq.c:1128: warning: 'msg' might be used uninitialized in this function

All the patch does is remove the duplicate check and shift everything 
else over.


Mark F. Haigh
Mark.Haigh@spirentcom.com