public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@home-tj.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: ide and ROMs
Date: Fri, 04 Feb 2005 07:05:53 +0900	[thread overview]
Message-ID: <4202A041.3030808@home-tj.org> (raw)
In-Reply-To: <9e4733910502011957145191f5@mail.gmail.com>

Jon Smirl wrote:
> Since it looks like ide is being worked on, can you convert ide to use
> the PCI ROM access calls in drivers/pci/rom.c instead of directly
> manipulating PCI config space? The new ROM calls work on all
> architectures.
> 
> These are the places that need to be fix:
> [jonsmirl@jonsmirl ide]$ grep -r PCI_ROM_ADDRESS_ENABLE *
> pci/aec62xx.c:          pci_write_config_dword(dev, PCI_ROM_ADDRESS,
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/cmd64x.c:           pci_write_config_byte(dev, PCI_ROM_ADDRESS,
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/hpt34x.c:                          
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/hpt366.c:                   dev->resource[PCI_ROM_RESOURCE].start
> | PCI_ROM_ADDRESS_ENABLE);
> pci/pdc202xx_new.c:                    
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/pdc202xx_old.c:                    
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> [jonsmirl@jonsmirl ide]$

Sure, I'll look at it.

-- 
tejun


      reply	other threads:[~2005-02-03 22:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02  3:57 ide and ROMs Jon Smirl
2005-02-03 22:05 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4202A041.3030808@home-tj.org \
    --to=tj@home-tj.org \
    --cc=jonsmirl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox