* [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning
@ 2005-02-08 4:53 Mark F. Haigh
2005-02-08 5:52 ` Mark F. Haigh
0 siblings, 1 reply; 3+ messages in thread
From: Mark F. Haigh @ 2005-02-08 4:53 UTC (permalink / raw)
To: marcelo.tosatti; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
Same patch, now against 2.4.29-bk8:
Noticed that in drivers/scsi/sym53c8xx.c:
sym53c8xx.c:13185: warning: integer constant is too large for "long" type
Since we're not dealing with C99 (yet), this 64 bit integer constant
needs to be suffixed with ULL. Patch included.
Mark F. Haigh
Mark.Haigh@spirentcom.com
[-- Attachment #2: sym53c8xx-patch --]
[-- Type: text/plain, Size: 413 bytes --]
--- drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.741527608 -0800
+++ drivers/scsi/sym53c8xx.c 2005-02-07 19:53:36.782808616 -0800
@@ -13182,7 +13182,7 @@
** descriptors.
*/
if (chip && (chip->features & FE_DAC)) {
- if (pci_set_dma_mask(pdev, (u64) 0xffffffffff))
+ if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL))
chip->features &= ~FE_DAC_IN_USE;
else
chip->features |= FE_DAC_IN_USE;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning
2005-02-08 4:53 [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning Mark F. Haigh
@ 2005-02-08 5:52 ` Mark F. Haigh
2005-02-08 6:15 ` Mark F. Haigh
0 siblings, 1 reply; 3+ messages in thread
From: Mark F. Haigh @ 2005-02-08 5:52 UTC (permalink / raw)
To: marcelo.tosatti; +Cc: Mark F. Haigh, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
Mark F. Haigh wrote:
>
> --- drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.741527608 -0800
> +++ drivers/scsi/sym53c8xx.c 2005-02-07 19:53:36.782808616 -0800
Apologies. Patch now -p1-able.
Mark F. Haigh
Mark.Haigh@spirentcom.com
Signed-off-by: Mark F. Haigh <Mark.Haigh@spirentcom.com>
[-- Attachment #2: sym53c8xx-patch2 --]
[-- Type: text/plain, Size: 447 bytes --]
--- linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.000000000 -0800
+++ linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c 2005-02-07 19:53:36.000000000 -0800
@@ -13182,7 +13182,7 @@
** descriptors.
*/
if (chip && (chip->features & FE_DAC)) {
- if (pci_set_dma_mask(pdev, (u64) 0xffffffffff))
+ if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL))
chip->features &= ~FE_DAC_IN_USE;
else
chip->features |= FE_DAC_IN_USE;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning
2005-02-08 5:52 ` Mark F. Haigh
@ 2005-02-08 6:15 ` Mark F. Haigh
0 siblings, 0 replies; 3+ messages in thread
From: Mark F. Haigh @ 2005-02-08 6:15 UTC (permalink / raw)
To: marcelo.tosatti; +Cc: Mark F. Haigh, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
Mark F. Haigh wrote:
>
> Apologies. Patch now -p1-able.
>
[Apolgies yet again, description included now]
Noticed that in drivers/scsi/sym53c8xx.c:
sym53c8xx.c:13185: warning: integer constant is too large for "long" type
Since we're not dealing with C99 (yet), this 64 bit integer constant
needs to be suffixed with ULL. Patch included.
Mark F. Haigh
Mark.Haigh@spirentcom.com
Signed-off-by: Mark F. Haigh <Mark.Haigh@spirentcom.com>
[-- Attachment #2: sym53c8xx-patch2 --]
[-- Type: text/plain, Size: 447 bytes --]
--- linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.000000000 -0800
+++ linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c 2005-02-07 19:53:36.000000000 -0800
@@ -13182,7 +13182,7 @@
** descriptors.
*/
if (chip && (chip->features & FE_DAC)) {
- if (pci_set_dma_mask(pdev, (u64) 0xffffffffff))
+ if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL))
chip->features &= ~FE_DAC_IN_USE;
else
chip->features |= FE_DAC_IN_USE;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-08 6:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-08 4:53 [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning Mark F. Haigh
2005-02-08 5:52 ` Mark F. Haigh
2005-02-08 6:15 ` Mark F. Haigh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox