From: "Mark F. Haigh" <Mark.Haigh@spirentcom.com>
To: marcelo.tosatti@cyclades.com
Cc: "Mark F. Haigh" <Mark.Haigh@spirentcom.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning
Date: Mon, 07 Feb 2005 22:15:40 -0800 [thread overview]
Message-ID: <4208590C.1040500@spirentcom.com> (raw)
In-Reply-To: <420853A2.2010405@spirentcom.com>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
Mark F. Haigh wrote:
>
> Apologies. Patch now -p1-able.
>
[Apolgies yet again, description included now]
Noticed that in drivers/scsi/sym53c8xx.c:
sym53c8xx.c:13185: warning: integer constant is too large for "long" type
Since we're not dealing with C99 (yet), this 64 bit integer constant
needs to be suffixed with ULL. Patch included.
Mark F. Haigh
Mark.Haigh@spirentcom.com
Signed-off-by: Mark F. Haigh <Mark.Haigh@spirentcom.com>
[-- Attachment #2: sym53c8xx-patch2 --]
[-- Type: text/plain, Size: 447 bytes --]
--- linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.000000000 -0800
+++ linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c 2005-02-07 19:53:36.000000000 -0800
@@ -13182,7 +13182,7 @@
** descriptors.
*/
if (chip && (chip->features & FE_DAC)) {
- if (pci_set_dma_mask(pdev, (u64) 0xffffffffff))
+ if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL))
chip->features &= ~FE_DAC_IN_USE;
else
chip->features |= FE_DAC_IN_USE;
prev parent reply other threads:[~2005-02-08 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 4:53 [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning Mark F. Haigh
2005-02-08 5:52 ` Mark F. Haigh
2005-02-08 6:15 ` Mark F. Haigh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4208590C.1040500@spirentcom.com \
--to=mark.haigh@spirentcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox